-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starting IPFS in Desktop or in Brave Browser Nightly 1.33.x Cycles Network Printer Power #8534
Comments
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
@eDave56 thank you for taking the time to report this in such detail!
@eDave56Is it possible for you to capture local network traffic and share the WireShark dump? (attach a ZIP to a GitHub comment or share a CID). |
Never seen something like this. |
Here is one of the captures I did with WireShark. I can do more if need be. I also have captures using PacketPeeper. My machine in the capture is 192.168.1.14 If there's a download for a version of the IPFS Desktop application that uses the old spec I'm happy to download, install, and try it to see if it causes the same behavior as 0.17.0. Actually, the Brave Release, Beta, and Dev versions I tested didn't produce the behavior. If they use the old spec, wouldn't that be pretty strong evidence that it's the new spec doing it? |
Still occurs on Brave Browser Nightly 1.33.57 Mac/Win:
|
Just quickly glanced over this one and it rang a bell; unless configured not to do so, IPFS will try to connect to local nodes on LAN-addresses at whatever address and port other nodes advertise themselves as. It's quite possible some printers are set to wake up when a certain point is connected to and it's quite possible that this happens. Normally, one would filter IPFS not to make LAN connections, as would be the case for the server profile. But perhaps we should be even smarter and not try to make connections to not-routable subnets which we're not in. |
Interesting, and that makes sense, but that's not what is happening with the printer here. The printer isn't waking up, but is actually rebooting and nagging me that it was not powered off properly afterwards. Or maybe it is waking up, but the Canon software gets carried away and wakes it up then reboots it? |
Still occurs with Brave Browser Nightly 1.33.62. Details here. |
I downloaded current and three old versions of IPFS Desktop for macOS and have tested them. I've downloaded the same for Windows, but don't have time to test tonight.
OS: macOS Version 10.14.6 (Build 18G9323) |
@eDave56 i think what matters now is the version of go-ipfs. (Brave/Desktop/webui do not seem relevant) Could you try installing older versions of go-ipfs like 0.9.1 and 0.8.0 and run |
The printer was in some weird state where it responded to scan request, but when I went to it and checked it it cycled power and nagged me, and now Nightly and IPFS Desktop reboot the printer when launched with IPFS local node enabled, again. I had installed IPFS Desktop 0.14, 0.15, 0.16, and 0.17 yesterday and found only 0.17 rebooted the printer. It still does. |
Sounds like a buffer overflow in the printer or something other than that; unexpected input causing the printer to acutely crash, then some watchdog restarts it.
|
OK, I started with 0.8.0 - ran without rebooting printer After I took that screenshot and after the printer was done rebooting, these messages appeared in Terminal: |
From what I've read, it looks like Canon has been pretty unconcerned with such flaws in the past. Maybe that's all it is. And the firmware is kind of old. I experimented with the different services the printer offers, and while the effect is cross platform, it looks like it's Canon's implementation of Bonjour that may be the issue. I have Bonjour installed on the Windows box, too, so it's a possibility. The Linux box not causing the effect might bolster this theory since as far as I know I don't have Bonjour installed in that distro. Turning off WSD and LPR/D didn't stop the reboot. Turning off Bonjour, too, of course, rendered the printer unusable as a standalone, unless there's an option I missed. I can just leave IPFS off until the damned printer breaks if it's too much hassle to continue working on this. |
Thank you for narrowing this down to go-ipfs 0.10.0. @marten-seemann @aschmahmann my understanding is that this is caused by the new mdns implementation in go-libp2p:
|
Thank you, @lidel . Is there a timeline for the release of 0.11.0? I poked around and didn't see one, but my github skills are feeble. |
It should land on the next few weeks, before December holidays. |
@eDave56 are you able to see if go-ipfs v0.11.0-rc1 fixes this issue? We switched to go-libp2p 0.16, assuming it is fixed. |
It looks like go-ipfs v0.11.0-rc1 has fixed the issue. It's been running for about 10 minutes and the printer hasn't made a peep. Thank you! Now I just need to wait for its integration into Brave. |
This TCP error message is unrelated (printer issue was caused by UDP packets) :) |
Enabling/updating Brave Nightly 1.33.x with IPFS enabled to local node or launching IPFS desktop application 0.17.0 causes network printer to reboot/restart/cycle power. It might just be my printer but it's weird. Sometimes the printer becomes unresponsive after the event.
OS: macOS 10.14.6 (Build 18G9323), macOS 11.6 (Build 20G165), Windows 10 Version 21H1 (Build 19043.1288)
Version of IPFS Desktop: 0.17.0
IPFS in Brave Browser Nightly 1.33.x at least as early as 1.33.7 for macOS, 1.33.34 for Windows 10
Printer: Canon Pixma 710 Series
And the Macs report this:
2012 13" MBP Mojave:
2015 13" MBA Big Sur:
Describe the bug
Starting IPFS Desktop application or enabling it in Brave Nightly 1.33.x causes printer to cycle power / reboot.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Printer should be unaffected.
Additional context
First associated the printer cycling with updating Brave Browser Nightly to 1.33.7, narrowed it down to enabling/updating with IPFS enabled to local node in Brave Nightly, then confirmed it occurs with the IPFS desktop application.
Also initially thought it was macOS-only, but with at least Brave Nightly 1.33.34 and with Desktop 0.17.0, it's both macOS and Windows. On the Linux machine I have running (Lite Ubuntu 20.04) I have not yet been able to reproduce this effect.
I have captured network traffic during IPFS startup with WireShark and PacketPeeper if those would help.
I have a record of sorts in the issue I started on the Brave GitHub site:
brave/brave-browser#19007
Also my initial thread in the Brave Community:
https://community.brave.com/t/ipfs-cycles-network-printer-power-was-update-brave-nightly-cycles-network-printer-power/291260/2
The text was updated successfully, but these errors were encountered: