-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Ethereum example? #74
Comments
Sounds reasonable to me :) If we lose part of the message that IPLD is interoperable by removing one good example, perhaps we can find another good example that does work on go-ipfs by default. |
Is this something we should remove without a replacement? or is there a suggestion for a replacement we could use? |
Remove it, nobody cared about this enough to fix it for more multiple years, and makes more harm than good. We should not wait for good replacement. |
related: ipfs/js-ipfs#1453 |
Linking this comment here: https://github.com/ipfs/ipld-explorer-components/pull/360/files/09ab5e813ff38395528ae3ca798e0d7b1e1dea70#r1218762651 All that said I have no strong feelings about removing/not removing the ethereum examples here, just providing some context and potential options. |
I was just about to add a link to your comment, thanks for adding that. I think until we have a good plan forward for ipld-ethereum examples, or a need for users of explore.ipld.io to have ethereum codecs, we should put this on the back burner. |
I believe this example makes more harm than good.
go-ipfs 0.12.0 does not ship with ethereum codec, and when someone tries to open/traverse the DAG it in ANY of our existing IPFS tooling, they get an error:
My take: examples should be educational, not confusion-inducing.
Ok to remove it?
cc @mikeal @warpfork @mvdan
The text was updated successfully, but these errors were encountered: