Client attempts to register with invalid port

[2color]

Problem

When a host is started with NAT Port Mapping enabled as in the following example it often starts by getting a temporary multiaddr with the port 0. Since this is invalid, perhaps the p2p-forge client should avoid even trying to register with such a multiaddr

Example log:

2024-12-18T20:10:48.202+0100	INFO	autotls	autotls/main.go:86	Host created: 12D3KooWHsg4mRStpUB5t9qMx4pAJUaWnKJNEyDoMo3rdYWRsiHp
2024-12-18T20:10:55.933+0100	INFO	autotls	autotls/main.go:106	Addresses: [/ip4/78.55.181.170/tcp/0 /ip4/127.0.0.1/tcp/15000 /ip4/192.168.178.21/tcp/15000]
2024-12-18T20:11:02.719+0100	ERROR	p2p-forge/client.obtain	[email protected]/config.go:639	could not get certificate from issuer	{"identifier": "*.k51qzi5uqu5dj603v9fpefsx1bo4877i6ox86nheo4bx6vc3tjyj7ldy2dmvur.libp2p.direct", "issuer": "acme-staging-v02.api.letsencrypt.org-directory", "error": "[*.k51qzi5uqu5dj603v9fpefsx1bo4877i6ox86nheo4bx6vc3tjyj7ldy2dmvur.libp2p.direct] solving challenges: presenting for challenge: 400 Bad Request : error testing addresses: failed to dial: failed to dial 12D3KooWHsg4mRStpUB5t9qMx4pAJUaWnKJNEyDoMo3rdYWRsiHp: all dials failed\n  * [/ip4/78.55.181.170/tcp/0] dial tcp4 78.55.181.170:0: i/o timeout (order=https://acme-staging-v02.api.letsencrypt.org/acme/order/176688044/21403961634) (ca=https://acme-staging-v02.api.letsencrypt.org/directory)"}
2024-12-18T20:11:02.719+0100	ERROR	p2p-forge/client.obtain	[email protected]/async.go:117	will retry	{"error": "[*.k51qzi5uqu5dj603v9fpefsx1bo4877i6ox86nheo4bx6vc3tjyj7ldy2dmvur.libp2p.direct] Obtain: [*.k51qzi5uqu5dj603v9fpefsx1bo4877i6ox86nheo4bx6vc3tjyj7ldy2dmvur.libp2p.direct] solving challenges: presenting for challenge: 400 Bad Request : error testing addresses: failed to dial: failed to dial 12D3KooWHsg4mRStpUB5t9qMx4pAJUaWnKJNEyDoMo3rdYWRsiHp: all dials failed\n  * [/ip4/78.55.181.170/tcp/0] dial tcp4 78.55.181.170:0: i/o timeout (order=https://acme-staging-v02.api.letsencrypt.org/acme/order/176688044/21403961634) (ca=https://acme-staging-v02.api.letsencrypt.org/directory)", "attempt": 1, "retrying_in": 60, "elapsed": 6.768573083, "max_duration": 2592000}





2024-12-18T20:12:16.882+0100	INFO	autotls	autotls/main.go:112	TLS certificate loaded
2024-12-18T20:12:16.883+0100	INFO	autotls	autotls/main.go:113	Addresses: [/ip4/78.55.181.170/tcp/12609 /ip4/78.55.181.170/tcp/18578/tls/sni/78-55-181-170.k51qzi5uqu5dj603v9fpefsx1bo4877i6ox86nheo4bx6vc3tjyj7ldy2dmvur.libp2p.direct/ws /ip4/127.0.0.1/tcp/15000 /ip4/192.168.178.21/tcp/15000]
^C⏎
➜  autotls git:(add-autotls-example) go run .
2024-12-18T20:18:05.143+0100	INFO	autotls	autotls/main.go:86	Host created: 12D3KooWQDGXrZ2EUAANBzAoo24j4KwoQFnPhe7d6rodEo85foHS
2024-12-18T20:18:12.949+0100	INFO	autotls	autotls/main.go:106	Addresses: [/ip4/78.55.181.170/tcp/65449 /ip4/127.0.0.1/tcp/15000 /ip4/192.168.178.21/tcp/15000]


^Csignal: interrupt
➜  autotls git:(add-autotls-example) go run .
2024-12-18T22:25:48.358+0100	INFO	autotls	autotls/main.go:86	Host created: 12D3KooWHme6MFEiQLvwicbgDoLabiHjPX9RPqXjfVuwuRhS7be6
2024-12-18T22:25:55.837+0100	INFO	autotls	autotls/main.go:106	Addresses: [/ip4/78.55.181.170/tcp/0 /ip4/127.0.0.1/tcp/15000 /ip4/192.168.178.21/tcp/15000]
2024-12-18T22:25:58.386+0100	ERROR	p2p-forge/client.obtain	[email protected]/config.go:639	could not get certificate from issuer	{"identifier": "*.k51qzi5uqu5dj4m6dkasyhqq0y8rp7gcq94myme6onvybsux9374sevrlkot67.libp2p.direct", "issuer": "acme-staging-v02.api.letsencrypt.org-directory", "error": "[*.k51qzi5uqu5dj4m6dkasyhqq0y8rp7gcq94myme6onvybsux9374sevrlkot67.libp2p.direct] solving challenges: presenting for challenge: 400 Bad Request : error testing addresses: failed to dial: failed to dial 12D3KooWHme6MFEiQLvwicbgDoLabiHjPX9RPqXjfVuwuRhS7be6: all dials failed\n  * [/ip4/78.55.181.170/tcp/0] dial tcp4 78.55.181.170:0: connect: no route to host (order=https://acme-staging-v02.api.letsencrypt.org/acme/order/176688044/21406489914) (ca=https://acme-staging-v02.api.letsencrypt.org/directory)"}
2024-12-18T22:25:58.386+0100	ERROR	p2p-forge/client.obtain	[email protected]/async.go:117	will retry	{"error": "[*.k51qzi5uqu5dj4m6dkasyhqq0y8rp7gcq94myme6onvybsux9374sevrlkot67.libp2p.direct] Obtain: [*.k51qzi5uqu5dj4m6dkasyhqq0y8rp7gcq94myme6onvybsux9374sevrlkot67.libp2p.direct] solving challenges: presenting for challenge: 400 Bad Request : error testing addresses: failed to dial: failed to dial 12D3KooWHme6MFEiQLvwicbgDoLabiHjPX9RPqXjfVuwuRhS7be6: all dials failed\n  * [/ip4/78.55.181.170/tcp/0] dial tcp4 78.55.181.170:0: connect: no route to host (order=https://acme-staging-v02.api.letsencrypt.org/acme/order/176688044/21406489914) (ca=https://acme-staging-v02.api.letsencrypt.org/directory)", "tempt": 1, "retrying_in": 60, "elapsed": 2.536293625, "max_duration": 2592000}