Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code folding triangle overlaps code for cells in reloaded notebooks #988

Closed
abprice opened this issue May 15, 2017 · 9 comments
Closed

Code folding triangle overlaps code for cells in reloaded notebooks #988

abprice opened this issue May 15, 2017 · 9 comments

Comments

@abprice
Copy link

abprice commented May 15, 2017

The code folding triangle overlaps the code text it corresponds with and there is no vertical line separating the gutter from the rest of the code cell when a notebook is reloaded.

New cells render the code folding triangle and vertical gutter line as expected. The issue is resolved in preexisting cells if the toggle line numbers extension is activated.

Could this be due to a conflicting extension?

codefolding_issue

@jcb91
Copy link
Member

jcb91 commented May 15, 2017

This is (I think) also what's behind #982. I've seen it in the past, but it seems to be working ok for me at the moment in notebook 5.x. This may be a result of the notebook version, or (as you mention) it may be a result of interactions with other nbextensions.

What versions of notebook and the nbextensions repo are you using? What other nbextensions do you have enabled? Does disabling any of them fix this for you?

@abprice
Copy link
Author

abprice commented May 15, 2017

I get the issue for both notebook versions 4.3.1 and 5.0.0 (different conda environments).

I have tried disabling all extensions other than codefolding (in notebook 5.0.0), but the issue persists.
I generally have the extensions shown in the attached image enabled.

nbextensions_5

@jcb91
Copy link
Member

jcb91 commented May 15, 2017

Ok. I guess you're using the latest conda release (0.2.7?) rather than the repo master? There's a fix in #977 which is likely to fix this for you. You can try applying it yourself if you're comfortable with trying that, otherwise, since you're at least the second person to have run into this, I'll roll another release tonight...

@abprice
Copy link
Author

abprice commented May 15, 2017

Ya, I am on 0.2.7. I will wait for the release tonight. Thanks.

@jcb91
Copy link
Member

jcb91 commented May 15, 2017

Ok, 0.2.8 is live as a GitHub tag and on pypi, conda-forge release to follow once conda-forge/jupyter_contrib_nbextensions-feedstock#17 is merged & the resultant CI builds complete...

@jcb91
Copy link
Member

jcb91 commented May 16, 2017

and, now on conda-forge also. Closing this as fixed, but obviously please reopen if you find 0.2.8 doesn't fix it for you.

@jetheurer
Copy link

I have the same problem running on Linux 4.4.0-77-generic#98-Ubuntu SMP x86_64 x86_64 x86_64 GNU/Linux

jupyter (1.0.0)
jupyter-client (5.1.0)
jupyter-console (5.1.0)
jupyter-contrib-core (0.3.1)
jupyter-contrib-nbextensions (0.2.8)
jupyter-core (4.3.0)
jupyter-highlight-selected-word (0.0.11)
jupyter-latex-envs (1.3.8.4)
jupyter-nbextensions-configurator (0.2.5)

@juhasch
Copy link
Member

juhasch commented Jul 22, 2017

Sorry to hear that. Unfortunately, there are some subtle race conditions when loading extensions.
Does this happen with a specific notebook (e.g. a large one) ?

@juhasch
Copy link
Member

juhasch commented Jul 22, 2017

If you checkout PR #1028, you can try setting a delay parameter to see if things improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants