Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tuner][Codegen] Allow for tuning specs to override codegen pipeline without setting full lowering config #19674

Open
kuhar opened this issue Jan 10, 2025 · 4 comments
Labels
enhancement ➕ New feature or request tuner

Comments

@kuhar
Copy link
Member

kuhar commented Jan 10, 2025

This is when we want to force a specific codegen pipeline but still want to rely on compiler heuristics choosing the exact lowering config.

@kuhar kuhar added enhancement ➕ New feature or request tuner labels Jan 10, 2025
@qedawkins
Copy link
Contributor

What kind of case do you have in mind? I would expect any case where we want to force a pipeline is just an artifact of that pipeline not being the default choice.

@kuhar
Copy link
Member Author

kuhar commented Jan 10, 2025

Basically any time we don't like the default choice, e.g., sending an MMT down TileAndFuse or WarpReduction instead of VectorDistribution.

@qedawkins
Copy link
Contributor

I see that as a transient issue with having too many pipelines. Over time we expect to only have 2 or 3 (a main default one and a few others for very specific cases). Think some amalgamation of TileAndFuse and VectorDistribution that handles WarpReduction also.

We could add optimization hints that indicate the kind of algorithm we want to use. For matmuls that could be an enum for WarpReduce, MFMA, and SIMT (as an example). Today that would just select between the different pipelines, and in the future a unified pipeline would just pick a config based on the hint. WDYT?

@kuhar
Copy link
Member Author

kuhar commented Jan 10, 2025

I think that's reasonable, let's chat about this next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ➕ New feature or request tuner
Projects
None yet
Development

No branches or pull requests

2 participants