Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the import of imp.find_module. #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abadger
Copy link

@abadger abadger commented Jun 13, 2022

Usage of find_module has been replaced by importlib.

The imp module is going to be removed in python 3.12

Usage of find_module has been replaced by importlib.

The imp module is going to be removed in python 3.12
@ferdnyc
Copy link

ferdnyc commented Jan 25, 2024

@ironfroggy Any chance you could merge this and do a new straight.plugin release, please? imp is indeed gone in Python 3.12, and while straight.plugin==1.5.0 can be made to work by installing zombie-imp, switching to importlib is a no-brainer. (Particularly since imp.find_module isn't even used.)

pypingou pushed a commit to Pagure/pagure that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants