Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incompatibilities with DAE #318

Open
Kregoras opened this issue Dec 16, 2024 · 2 comments
Open

[BUG] Incompatibilities with DAE #318

Kregoras opened this issue Dec 16, 2024 · 2 comments

Comments

@Kregoras
Copy link

Describe the bug
When installed with newest DAE version for DnD5e 4.1+ when an effect is assigned like disengage via token menu, when the effect is disabled Foundry get's frozen.

To Reproduce
Steps to reproduce the behavior:

  1. Install both modules, monks-little-details and DAE (with dependencies)
  2. Create a new character
  3. Place character on table
  4. Select token
  5. Apply the effect Disengage via menu
  6. Remove the effect via token menu
  7. Browser is frozen (a browser reload is required, foundry keeps working) and the effect is not removed.

Expected behavior
Remove the effect and do not freeze the browser

Screenshots
Captura de pantalla 2024-12-16 204007
Captura de pantalla 2024-12-16 204135

Please complete as much of the following information as possible:

  • Browser [Chrome, Edge and inbuilt Foundry browser]
  • Foundry Version [e.g. v12]
  • System [DnD5e 4.1.2]
  • Module version: DAE 12.0.6.2, Monk's lil details 12.04, socketlib 1.1.0 and libwrapper 1.13.2.0
  • Are there any errors in the console: Apparently not
  • Have you tried using Find the Culprit to make sure it isn't a module interaction. I narrowed it to both modules stated.

Additional context
Add any other context about the problem here.

@davidhawbecker
Copy link

Can confirm this bug. Same thing happening here and I'm on v12 and 5e. 3.3.1.

@ChrisRosser
Copy link

I also have the issue!

For me there are two concentrating effects. One works correctly. The other throws this error on being applied:

Error: The async option for Roll#evaluate has been removed. Use Roll#evaluateSync for synchronous roll evaluation.
    at Object.logCompatibilityWarning (foundry-esm.js:4609:19)
    at Roll.evaluate (foundry-esm.js:63561:23)
    at enrichDamage (enrichers.mjs:382:51)
    at enrichString (enrichers.mjs:55:27)
    at _replaceTextContent.replaceParent.replaceParent (foundry.js:69632:61)
    at TextEditor._replaceTextContent (foundry.js:69752:26)
    at async TextEditor.enrichHTML (foundry.js:69530:25)
    at async #k (action-handler.js:1571:46)
    at async #w (action-handler.js:1201:17)
    at async action-handler.js:1146:67
    at async Promise.all (index 3)
    at async ActionHandler.buildActions (action-handler.js:1146:19)
    at async ActionHandler.buildActivations (action-handler.js:308:56)
    at async #d (action-handler.js:812:26)
    at async Promise.all (index 3)
    at async #i (action-handler.js:152:9)
    at async ActionHandler.buildSystemActions (action-handler.js:129:21)
    at async #h (action-handler.js:208:72)
    at async Promise.all (index 0)
    at async ActionHandler.buildHud (action-handler.js:98:31)
    at async #It (token-action-hud.js:1157:14)
    at async TokenActionHud.update (token-action-hud.js:1093:20)

And locks the browser up on being removed with this repeating error message:

DEBUG | Automated Animations | No Animation matched for Item {token: Token5e, targets: Array(0), item: ActiveEffect5e, activeEffect: true}
constants.js:3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants