Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Extend ContactSensorData by force_matrix_w_history attribute #1720

Open
1 of 3 tasks
lukasfro opened this issue Jan 24, 2025 · 2 comments · May be fixed by #1746
Open
1 of 3 tasks

[Proposal] Extend ContactSensorData by force_matrix_w_history attribute #1720

lukasfro opened this issue Jan 24, 2025 · 2 comments · May be fixed by #1746
Assignees
Labels
enhancement New feature or request

Comments

@lukasfro
Copy link

lukasfro commented Jan 24, 2025

Proposal

Similar to the net_forces_w_history attribute that keeps a history of net_forces_w, I propose to add a force_matrix_w_history attribute storing the history of force_matrix_w when using the ContactSensor with filtered bodies.

Motivation

Depending on the decimation factor, we noticed that it is critical to consider the full history of the contact sensor. This is in accordance with how the illegal_contact termination is computed for the unfiltered contact forces here. When filtering the collision bodies, this functionality does not exist currently. I'm happy to open a PR for this feature. We have been using this internally already.

Alternatives

I don't see any alternatives to this.

Additional context

None

Checklist

  • I have checked that there is no similar issue in the repo (required)

Acceptance Criteria

Add the criteria for which this task is considered done. If not known at issue creation time, you can add this once the issue is assigned.

  • Criteria 1
  • Criteria 2
@RandomOakForest
Copy link
Collaborator

Thank you for posting this proposal. The team will review.

@RandomOakForest RandomOakForest added the enhancement New feature or request label Jan 24, 2025
@RandomOakForest
Copy link
Collaborator

Following up on this feature request. The team would welcome a PR may you have time to submit one. Thanks.

@lukasfro lukasfro linked a pull request Jan 28, 2025 that will close this issue
6 tasks
@kellyguo11 kellyguo11 self-assigned this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants