-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dart language support #426
Conversation
It looks like we should reuse |
Yes, but we should choose another name. @Deprecated
class SomeClass {} |
I'm happy with .hljs-dartdoc for now because it's consistent with javadoc, phpdoc and some others. This is not an ideal situation and we're gonna deal with it as a part of the overall unification/simplification of styling classes (see also #348) which is bound to be backwards-incompatible and thus won't happen very soon. |
Any updates on this? Would be a great addition to |
I've rebased this against |
Rebase against new updated master |
Any thoughts about this pull request? What prevents it from being merged into master? |
@dikmax we'll get around to it when time allows. We'd all want things to happen faster, but there's only so much we can do, sorry! |
Oh, and thanks a lot for rebasing the branch! |
Aside from dealing with the merge conflicts at the time of writing this comment, is there anything else you the owners/contributors to |
I'm working on it in my local branch now. It needed some work on cross-language relevance and I hope to have it merged this week (this week is my "highlight.js" week :-) ) |
@isagalaev - thanks very much in advance! |
It looks like I merged the other PR, #516 after all. But I suppose they are functionally equivalent. One thing of note is that dartdoc is styled in bold font in default.css which to my eye looks wrong. I'll be happy to merge another PR removing dartdoc-specific rules but I'll let you (collectively) be the judge on that one. |
Added Dart support (https://www.dartlang.org/).
New CSS class
.hljs-dartdoc
added to every style in same place as.hljs-phpdoc
.