Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to line 155 of fetchOrbit.py #282

Merged
merged 1 commit into from
May 11, 2021
Merged

Changes to line 155 of fetchOrbit.py #282

merged 1 commit into from
May 11, 2021

Conversation

bjmarfito
Copy link
Contributor

I've made some changes to fetchOrbit.py due to changes made by ESA based on the issue presented in #273 (comment).

I've made some changes to fetchOrbit.py due to changes made by ESA based on the issue presented in #273 (comment).
@yuankailiu
Copy link
Contributor

Thanks, @bjmarfito. This works well for me for both the precise and restituted orbits.

@bjmarfito
Copy link
Contributor Author

Thank you @yuankailiu for testing it.

Xiaohua-Eric-Xu pushed a commit to gmtsar/gmtsar that referenced this pull request May 7, 2021
I've made some changes to fetchOrbit.py due to changes made by ESA once again based on the issue presented in #273 (comment). I've mirrored this PR from isce-framework/isce2#282.

Hopefully, ESA would not change it again frantically.
@piyushrpt piyushrpt requested review from rtburns-jpl and yunjunz May 9, 2021 19:04
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it again.

@rtburns-jpl rtburns-jpl linked an issue May 11, 2021 that may be closed by this pull request
Copy link
Member

@rtburns-jpl rtburns-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks reasonable so I'll merge based on the approvals. Thanks again to all for the bugfix and code reviews :)

@rtburns-jpl rtburns-jpl merged commit 19b754d into isce-framework:main May 11, 2021
@bjmarfito
Copy link
Contributor Author

Thank you @rtburns-jpl and @yunjunz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new fetchOrbit - slight change necessary?
4 participants