Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runIon: import cpu-, gpu-dependent resamp funcs #420

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

yuankailiu
Copy link
Contributor

The original code uses
from isceobj.TopsProc.runFineResamp import resampSecondary

But the runFineResamp.py has split the resampSecondary() function into two: resampSecondary_CPU() and resampSecondary_GPU().

So this PR fixes this bug by identifying whether to use CPU or GPU.

Copy link
Member

@rtburns-jpl rtburns-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuankailiu
Copy link
Contributor Author

Sorry, will this be merged into the main branch? I think it passes the review.

Copy link
Collaborator

@hfattahi hfattahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @yuankailiu.

@hfattahi hfattahi merged commit 828cf15 into isce-framework:main Feb 2, 2022
yuankailiu added a commit to yuankailiu/isce2 that referenced this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants