Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UAVSAR_Stack: bugfix for line/sample num and dopplerFile path #431

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Jan 17, 2022

This PR fixes the following two bugs in UAVSAR_Stack.py:

  • UAVSAR_Stack: use segment index while setting the number of lines / samples
  • UAVSAR_Stack: use self.dopplerFile if it exists, otherwise use the path from *.ann file, to support unpackFrame_UAVSAR.py when dop file is not in the current directory
  • unpackFrame_UAVSAR: rename variables and comments to improve code readability

+ UAVSAR_Stack: use segment index while setting the number of lines / samples
+ UAVSAR_Stack: use self.dopplerFile if it exists otherwise use the path from *.ann file, to support unpackFrame_UAVSAR.py when dop file is not in the current directory
+ unpackFrame_UAVSAR: rename variables and comments to improve code readability
Copy link
Member

@rtburns-jpl rtburns-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a couple small nits

Copy link
Member

@rtburns-jpl rtburns-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@rtburns-jpl rtburns-jpl merged commit 9adf195 into isce-framework:main Feb 1, 2022
@yunjunz yunjunz deleted the uav branch February 1, 2022 23:07
yuankailiu pushed a commit to yuankailiu/isce2 that referenced this pull request Feb 17, 2022
…ramework#431)

* UAVSAR_Stack: bugfix for line/sample num and dopplerFile path
+ UAVSAR_Stack: use segment index while setting the number of lines / samples
+ UAVSAR_Stack: use self.dopplerFile if it exists otherwise use the path from *.ann file, to support unpackFrame_UAVSAR.py when dop file is not in the current directory
+ unpackFrame_UAVSAR: rename variables and comments to improve code readability

* use getattr() instead of hasattr()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants