Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on moving this project to the @getsops org? #164

Closed
Gowiem opened this issue Jan 30, 2024 · 3 comments
Closed

Thoughts on moving this project to the @getsops org? #164

Gowiem opened this issue Jan 30, 2024 · 3 comments
Labels
question Further information is requested

Comments

@Gowiem
Copy link

Gowiem commented Jan 30, 2024

This operator is fantastic. My team and I have used it on a few different projects with a lot of success. Now that SOPS is a part of the CNCF and they have their own org @getsops, is there any intention to move this project there where it could get more visibility / official support?

@isindir
Copy link
Owner

isindir commented Jan 31, 2024

@Gowiem that is interesting. I'm not sure if @getsops org would be interested in this, there is certain specific blocker:

and more context for this is here:

Main two reasons behind this operator to ignore mac signature are:

  • if I try to use it as is - k8s mutates object in cluster and signature becomes invalid
  • if I wrap encrypted secret into some field of higher level abstraction - e.g. base64 encoded encrypted secret, the CRD partly looses its value - transparency for users who do not have privileges to decrypt this data and simplicity of changing. With current CRD these users are able to see keys, but not values, which may help to understand application config without leaking secrets at the expense of verification of the actual encrypted artifact.

This was a deliberate decision of mine to simplify usage without loosing transparency and simplicity, but conflicts with upstream sops ideology. An alternative to how I manage secrets is done in here: https://github.com/craftypath/sops-operator , however in my mind it improves security on behalf of making it more complex to manage CRs (with this operator one can just use sops cr.file.name.yaml to make changes).

Also I have originally written this operator for flux v1, but flux v2 now supports sops out of the box - https://fluxcd.io/flux/guides/mozilla-sops/ .

This operator perhaps still have some niche use cases, but generally I'd advise using more sophisticated methods of managing secrets in k8s gitops environment. For example, external secrets have some interesting features - like cluster wide secrets and secrets which are dynamically generated, for example for AWS ECR access.

I hope this answers your question ? 🤠

@Gowiem
Copy link
Author

Gowiem commented Jan 31, 2024

@isindir it does. The first thing that comes to mind is I wonder if some of those issues could be fixed with optional functionality that could be added to the upstream SOPS tool. But in general it is interesting to hear you suggest other options instead of this operator. Maybe I need to check out sops-operator more. I know of external-secrets, but maybe it has come along where it's more of interest.

Anyway, thanks for sharing your thoughts!

@Gowiem
Copy link
Author

Gowiem commented Jan 31, 2024

Ah in a quick look at sops-operator it seems far off from what you've provided in this operator! No legitimate documentation + no code changes in 2 years is a very quick deal breaker for me at least.

@isindir isindir added the question Further information is requested label Jan 31, 2024
@isindir isindir closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants