Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3d conflicts with pyigl #114

Closed
qianyizh opened this issue Dec 12, 2017 · 5 comments · Fixed by #127
Closed

py3d conflicts with pyigl #114

qianyizh opened this issue Dec 12, 2017 · 5 comments · Fixed by #127

Comments

@qianyizh
Copy link
Collaborator

Ubuntu 16.04
Open3D developing branch
libigl developing branch
Get segment fault from importing.

>>> import py3d
>>> import pyigl

Probably due to inconsistent pybind11 versions and naming conflict.

@qianyizh qianyizh added the bug label Dec 12, 2017
@qianyizh
Copy link
Collaborator Author

The reason seems to be double binding of std::vector<int>. Both Open3D and libigl does it and it conflicts. This behavior has been thoroughly discussed in:
pybind/pybind11#919

An update to the latest pybind11 should resolve this.
It is related to #18

@syncle
Copy link
Contributor

syncle commented Dec 12, 2017

Sounds good. Specifying name space like

import py3d as py3d

can avoid conflicts too, right?

@qianyizh
Copy link
Collaborator Author

Tried. Did not work.
pybind11 does something with the global environment.

@syncle
Copy link
Contributor

syncle commented Dec 12, 2017

Good to know. I tried to upgrade pybind11 a month ago, but it seems like non-trivial task.
Do you think upgrading pybind is top priority before release?

@qianyizh
Copy link
Collaborator Author

No. It is lower priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants