Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add Python 3.11 support? #5620

Closed
3 tasks done
hiyyg opened this issue Oct 27, 2022 · 19 comments · Fixed by #6288
Closed
3 tasks done

Request to add Python 3.11 support? #5620

hiyyg opened this issue Oct 27, 2022 · 19 comments · Fixed by #6288
Assignees

Comments

@hiyyg
Copy link

hiyyg commented Oct 27, 2022

Checklist

Proposed new feature or change

It might be much faster with the support of Python 3.11.

References

No response

Additional information

No response

@dancergraham
Copy link
Contributor

dancergraham commented Nov 18, 2022

The upgrade to Python 3.10 was blocked by Tensorflow and Pytorch. I don't know whether other dependencies will block Open3D but here are links to the Python 3.11 issues on those two :

Tensorflow: tensorflow/tensorflow#58032
Pytorch: pytorch/pytorch#86566

@johnthagen

This comment was marked as outdated.

@dancergraham
Copy link
Contributor

The correct Tensorflow 3.11 upstream issue is:

Good catch! updated...

@chibai
Copy link

chibai commented Dec 21, 2022

https://pypi.org/project/torch/1.13.1/#files

There's official pytoch1.31 on Linux python3.11
Hope it will work for open3d python3.11

@avielTevel
Copy link

any update? thanks!

@johnthagen
Copy link
Contributor

johnthagen commented Jan 1, 2023

I'm not a maintainer, but I presume still waiting for upstream dependencies to add support for 3.11.

@johnthagen
Copy link
Contributor

johnthagen commented Mar 16, 2023

@ssheorey ssheorey self-assigned this Mar 21, 2023
@johnthagen
Copy link
Contributor

johnthagen commented Mar 24, 2023

Update 2

Both PyTorch and Tensorflow now have stable releases with 3.11 support. 🎉

@sungminlee114
Copy link

Any updates?

@jackjansen
Copy link

Chiming in with a request for updates, specifically at ETA for an official pypi release that supports 3.11.

(Note that I am most definitely not complaining: many heartfelt kudos for the Open3D maintainers from my side!!)

But. Now that many of the CI/CD hosts (specifically GitHub Actions from Mac) have progressed to Python 3.11, and brew has progressed to Python 3.11, and cmake makes it incredibly difficult to select a specific Python life is becoming very difficult again.

And it's only half a year since I removed all the cruft in my build scripts because Python 3.10 wasn't supported by open3d....

@samypr100
Copy link
Contributor

samypr100 commented May 6, 2023

Some notes from my attempted upgrades of TF (no CUDA)

  • TF 2.9 and 2.10 upgrades seemed ok at a glance...
  • Upgrading to TF 2.11 would cause some minor fixable issues on the Open3D side e.g. moving Status::OK() to using OkStatus().
  • TF 2.12 is the first one with Python 3.11 support, but it would now require a C++17 build, in addition to some other minor fixes.
  • TF/TF-macos 2.13 seems to be the first one to support Python 3.11 ARM OSX support, so we'd have to wait on that one first or use tf-nightly 2.13 for macos arm which might be acceptable (Python3.11 arm64 wheels for tensorflow-macos tensorflow/tensorflow#60209)

The biggest issue I saw is that the new tensorflow would now require -DGLIBCXX_USE_CXX11_ABI=ON where as pytorch still needs -DGLIBCXX_USE_CXX11_ABI=OFF, so there's a conflict if we want to build both modules at the same time. Building pytorch from source seems to fix it, but can add extra hours to the build. (pytorch/pytorch#51039)

Given above it's possible to proceed with an upgrade, but it'd take some quite the amount work/effort.

@johnthagen
Copy link
Contributor

johnthagen commented May 15, 2023

@ssheorey @samypr100

tensorflow-macos uploaded Python 3.11 wheels today for 2.12.0

@Rheinwalt
Copy link

is there a working pip pkg for linux with python 3.11 and if yes where can I get it?

@johnthagen
Copy link
Contributor

@Rheinwalt No, Open3D doesn't support Python 3.11 yet. @ssheorey self assigned and all the needed dependencies support 3.11, but Open3D itself needs updates to support it.

@OlivierLDff
Copy link
Contributor

I've locally updated to pybind11 v2.11.1 and it compiles locally.

@aruiplex
Copy link

aruiplex commented Dec 8, 2023

Really need it, please.

@johnthagen
Copy link
Contributor

3.11 wheels have been published with 0.18:

@chibai
Copy link

chibai commented Jan 15, 2024

Great Job!
Now we can look forward to python3.12 support. Since Ubuntu 24.04 LTS will release next year, and it's default python3 version is supposed to be python 3.12

@johnthagen
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.