PR/39 Solucion de colision de enumerados #40
Conversation
Domi-ATLAS
added
backend
ocial/models.py
Outdated
| class Category(Enum): | ||
| SPORTS = 0 # , ("Sports") | ||
| MUSIC = 1 # , ("Music") | ||
| MARKETS = 2 # , ("Markets") | ||
| RELAX_ACTIVITIES = 3 # , ("Relax activities") | ||
| LIVE_CONCERT = 4 # , ("Live concert") |
There was a problem hiding this comment.
Igual sería mejor ponerlo solo como texto en ambos lados (o igual a la izquierda numero a la derecha texto funciona mejor?)
Me acabo de dar cuenta de esto que me genera el cliente:
| SPORTS = "Sports" # , ("Sports") | ||
| MUSIC = "Music" # , ("Music") | ||
| MARKETS = "Markets" # , ("Markets") | ||
| RELAX_ACTIVITIES = "Relax activities" # , ("Relax activities") | ||
| LIVE_CONCERT = "Live concert" # , ("Live concert") |
There was a problem hiding this comment.
| SPORTS = "Sports" # , ("Sports") | |
| MUSIC = "Music" # , ("Music") | |
| MARKETS = "Markets" # , ("Markets") | |
| RELAX_ACTIVITIES = "Relax activities" # , ("Relax activities") | |
| LIVE_CONCERT = "Live concert" # , ("Live concert") | |
| SPORTS = "Sports" | |
| MUSIC = "Music" | |
| MARKETS = "Markets" | |
| RELAX_ACTIVITIES = "Relax activities" | |
| LIVE_CONCERT = "Live concert" |
.github/workflows/openapi.yml
Outdated
There was a problem hiding this comment.
Este commit tmb habría que droppearlo
|
There was a problem hiding this comment.
@adrrf @Domi-ATLAS En lo que al cliente generado respecta, ya todo bien (al menos de momento).
En mi opinión faltan por eliminar los comentarios que aún quedan en el CategoryEnum por ser redundantes y no aportar nada de información extra, pero eso ya lo dejo en vuestras manos.
ferferga
dismissed
their stale review
Generación API correcta, falta eliminación de los comentarios para mi gusto, pero no es un blocker para mí
No description provided.