Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

feat(ratings): Migrado rating de event a user, corregido los modelos … #62

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

lDrakohh
Copy link
Contributor

…y los test de event ya funcionan

@lDrakohh lDrakohh added this to the S2 milestone Mar 20, 2024
@lDrakohh lDrakohh requested a review from adrrf March 20, 2024 20:36
@lDrakohh lDrakohh self-assigned this Mar 20, 2024
@lDrakohh
Copy link
Contributor Author

Test de event corregido
a

Los métodos de event siguen funcionando
a

Creación del rating
a

@adrrf adrrf requested review from fravilpae and Jeszamgue March 21, 2024 18:06
@@ -375,3 +385,64 @@ def post(self, request):
status=status.HTTP_400_BAD_REQUEST,
)
return Response(user_data, status=status.HTTP_200_OK)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

habria que comprobar que el usuario que crea el rating está logueado y que no es otro cliente y que no ha puesto ya una opinion sobre dicho cliente

user/views.py Outdated
@@ -146,6 +146,16 @@ def post(self, request, *args, **kwargs):

return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)

class ClientIDListView(APIView):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esto para que es?

Copy link
Contributor

@adrrf adrrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

que he aprobado sin querer

@lDrakohh lDrakohh force-pushed the feat/46-Rating-Migration branch from 7ed9792 to edcc756 Compare March 25, 2024 12:13
@lDrakohh
Copy link
Contributor Author

Terminado el migrado de ratings. Se comprueba siempre que esté logueado, que solo puedan comentar usuarios de tipo OcialUser, que solo puedan tener un comentario por cliente, que funcionan correctamente los métodos delete, create y put

@lDrakohh lDrakohh requested a review from adrrf March 25, 2024 12:14
@lDrakohh
Copy link
Contributor Author

Arreglado

@lDrakohh lDrakohh requested a review from adrrf March 26, 2024 18:58
Copy link
Contributor

@fravilpae fravilpae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funcionalmente, va todo bien. A la espera de si el cambio de usar el token está bien hecho

@adrrf adrrf force-pushed the feat/46-Rating-Migration branch from 0274c20 to 6d56d5f Compare March 28, 2024 08:56
@adrrf adrrf force-pushed the feat/46-Rating-Migration branch from 6d56d5f to 03a1ca1 Compare March 28, 2024 09:01
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
14.0% Duplication on New Code

See analysis details on SonarCloud

@adrrf adrrf merged commit d2d98dd into develop Mar 28, 2024
7 of 10 checks passed
@adrrf adrrf deleted the feat/46-Rating-Migration branch March 28, 2024 09:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants