Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

PR/212-delete-button-user #213

Merged
merged 8 commits into from
May 4, 2024
Merged

PR/212-delete-button-user #213

merged 8 commits into from
May 4, 2024

Conversation

cvsoult
Copy link
Contributor

@cvsoult cvsoult commented Apr 29, 2024

  • Añadido un botón para que usuarios y clientes puedan borrar su cuenta y datos relacionados.
  • Añadido un mensaje de confirmación antes del borrado.

Queda pendiente esperar a que la nueva función esté desplegada en backend para que se efectúe el borrado.

@cvsoult cvsoult added code Tasks related to coding enhancement New feature or request frontend Issues related to frontend development blocked Issues or PRs blocked because they depend on another ⚠️p3-necessary Priority 3: Important issues labels Apr 29, 2024
@cvsoult cvsoult marked this pull request as draft April 29, 2024 11:59
@ferferga
Copy link
Contributor

ferferga commented Apr 30, 2024 •
edited
Loading

@carvarsou Ya he mergeado #214, por lo que ya están disponibles los métodos de la API. Puedes rebasar esta rama e implementar ya las llamadas a la API por favor?

@cvsoult
Copy link
Contributor Author

cvsoult commented Apr 30, 2024

@carvarsou Ya he mergeado #214, por lo que ya están disponibles los métodos de la API. Puedes rebasar esta rama e implementar ya las llamadas a la API por favor?

Necesito que @adrrf despliegue backend de nuevo ya que el método todavía no está desplegado.

@cvsoult cvsoult force-pushed the feat/212-delete-button-user branch from bf04240 to ef88428 Compare April 30, 2024 11:57
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Apr 30, 2024 •
edited
Loading

Deploying ocial-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6139383
Status: ✅  Deploy successful!
Preview URL: https://e0447aac.ocial-app.pages.dev
Branch Preview URL: https://feat-212-delete-button-user.ocial-app.pages.dev

View logs

@cvsoult cvsoult marked this pull request as ready for review April 30, 2024 11:57
@cvsoult
Copy link
Contributor Author

cvsoult commented Apr 30, 2024

Ya se ha añadido el método correspondiente al composable de use-delete-account-alert.ts.

@cvsoult cvsoult linked an issue Apr 30, 2024 that may be closed by this pull request
Creacion de botón para eliminar cuenta de usuario o cliente #212
Open
ferferga
ferferga suggested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@ferferga ferferga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perdona por tardar tanto en poder revisar esta pull request 😅.
Cositas minúsculas (que prometo no tardar tanto en volver a revisar cuando estén!)

@cvsoult cvsoult requested review from ferferga and horgarler May 3, 2024 09:59
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cvsoult cvsoult merged commit 55b7220 into develop May 4, 2024
12 checks passed
@cvsoult cvsoult deleted the feat/212-delete-button-user branch May 4, 2024 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ferferga ferferga ferferga approved these changes

@fravilpae fravilpae Awaiting requested review from fravilpae

@Jeszamgue Jeszamgue Awaiting requested review from Jeszamgue

@horgarler horgarler Awaiting requested review from horgarler

Assignees

@cvsoult cvsoult

@Domi-ATLAS Domi-ATLAS

Labels
blocked Issues or PRs blocked because they depend on another code Tasks related to coding enhancement New feature or request frontend Issues related to frontend development ⚠️p3-necessary Priority 3: Important issues
Projects
Gestión del Proyecto
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creacion de botón para eliminar cuenta de usuario o cliente
3 participants
@cvsoult @ferferga @Domi-ATLAS