Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Doesn't detect PS2 HDD if there are a lot of drives in the system #28

Closed
1 task done
m87h opened this issue Mar 27, 2022 · 6 comments
Closed
1 task done
Assignees
Labels
bug Something isn't working
Milestone

Comments

@m87h
Copy link
Contributor

m87h commented Mar 27, 2022

Issue

I have about 20 drives (physical and virtual) in my system and HDL Batch Installer won't recognize my PS2 drive (currently drive number 20). I've encountered the same issue with HDL Dumb (which has a hardcoded limit of 16 drives), HDLBATCH and OPL Manager.

expected behaviour

Expected behavior: my PS2 HDD is found.

Program version

3.3.0 revision 1

other checks

@m87h m87h added the bug Something isn't working label Mar 27, 2022
@israpps
Copy link
Owner

israpps commented Mar 28, 2022

Hi!

This is an HDLDump issue, not directly related to my GUI.

I'll take a look at this in a few days...

However, if you want to speed up things a bit, please open a issue on HDLDump

@israpps
Copy link
Owner

israpps commented Mar 29, 2022

After a quick inspection it seems that HDLDump only iterates on the first 16 drives...

I already asked the project maintainer if such limit can be increased

@israpps
Copy link
Owner

israpps commented Apr 21, 2022

Already Opened a Pull Request on hdl-dump...

The maintainer said he isn´t aware of any issue....

Actually, hdl-dump of ancient times was limited to only 4 drives AFAIK

@israpps
Copy link
Owner

israpps commented Apr 22, 2022

Fixed on HdlDump mainstream

Merged to my own repo...

Update on your HDL Batch installer package with the HdlDump update feature

Or re-download package

@m87h
Copy link
Contributor Author

m87h commented Apr 24, 2022

Thanks for this @israpps. I can confirm that the drive (currently numbered 18) is now detected and I'm instead seeing the error associated with #29.

@israpps
Copy link
Owner

israpps commented Apr 24, 2022

Thanks for this @israpps. I can confirm that the drive (currently numbered 18) is now detected and I'm instead seeing the error associated with #29.

yeah, yesterday while i was drunk i fixed the issue...

I might release a fix today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants