Wrong exit code for out of memory run test suite

[eseliger]

Expected Behavior

nyc should exit with return code different from 0

Observed Behavior

It actually doesn't. Although, in my opinion, it should. Because a application that runs out of memory obviously failed and so should nyc. This caused some trouble in our CD pipeline, so it can be dangerous.

Suggestion

Using spawn instead of fork seems not to share the memory and kill nyc as well. As you can see, the output seems to be pretty different for a crashed process, I guess it's distinguishable, so there could be a detection for that.

const spawn = require('child_process').spawnSync;
const p = spawn('node', ['test.js']);
console.log(p.status);
console.log(p.signal);
console.log(p.error);

test.js:

let longArray = [1,2,3,4,5,6,7,8,9,0];
function appendLongArray() {
    longArray = [...longArray, ...longArray];
    appendLongArray();
    // process.exit(1); #2
}
appendLongArray();

Output for out of memory run application is:

null
SIGABRT
undefined

Output for a normal process:

0
null
undefined

Operating System: MacOS 10.12.6
node: 8.2.1
npm: 5.3

[bcoe]

@eseliger interesting, I wonder if the module signal-exit module we use to write reports when the application exits might be the culprit.

It might be worth disabling the handling of SIGARBT and seeing whether the issue continues (you could do this by temporarily modifying the signal-exit module in the node-modules folder). I would love some help digging into this if you're so inclined.

[JaKXz]

Closing in favour of #798. Thanks for the issue! Let me know if you think they should be separate issues