From 87cb2efc601036fbff89445a5e71faff437018a5 Mon Sep 17 00:00:00 2001 From: Vadim Eisenberg Date: Mon, 9 Jul 2018 19:00:09 +0300 Subject: [PATCH 1/4] add connection.requested_server_name attribute (SNI) Will use Envoy's Network::Connection::requestedServerName() method --- mixer/v1/global_dictionary.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/mixer/v1/global_dictionary.yaml b/mixer/v1/global_dictionary.yaml index e424801fd49..ff54c6264e5 100644 --- a/mixer/v1/global_dictionary.yaml +++ b/mixer/v1/global_dictionary.yaml @@ -186,6 +186,7 @@ - connection.sent.bytes - connection.sent.bytes_total - connection.duration +- connection.requested_server_name # context attributes - context.protocol From 255480b89d01298805661255eb56eee5bdd14a01 Mon Sep 17 00:00:00 2001 From: Vadim Eisenberg Date: Mon, 9 Jul 2018 19:17:20 +0300 Subject: [PATCH 2/4] connection.requested_server_name -> connection.received.requested_server_name --- mixer/v1/global_dictionary.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mixer/v1/global_dictionary.yaml b/mixer/v1/global_dictionary.yaml index ff54c6264e5..973e7e155f5 100644 --- a/mixer/v1/global_dictionary.yaml +++ b/mixer/v1/global_dictionary.yaml @@ -183,10 +183,10 @@ - connection.id - connection.received.bytes - connection.received.bytes_total +- connection.received.requested_server_name - connection.sent.bytes - connection.sent.bytes_total - connection.duration -- connection.requested_server_name # context attributes - context.protocol From 8dfa155e748730202cc93a67a803b44380c179c0 Mon Sep 17 00:00:00 2001 From: Vadim Eisenberg Date: Tue, 10 Jul 2018 09:38:24 +0300 Subject: [PATCH 3/4] Revert "connection.requested_server_name -> connection.received.requested_server_name" This reverts commit 255480b89d01298805661255eb56eee5bdd14a01. --- mixer/v1/global_dictionary.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mixer/v1/global_dictionary.yaml b/mixer/v1/global_dictionary.yaml index 973e7e155f5..ff54c6264e5 100644 --- a/mixer/v1/global_dictionary.yaml +++ b/mixer/v1/global_dictionary.yaml @@ -183,10 +183,10 @@ - connection.id - connection.received.bytes - connection.received.bytes_total -- connection.received.requested_server_name - connection.sent.bytes - connection.sent.bytes_total - connection.duration +- connection.requested_server_name # context attributes - context.protocol From 08d4a5067b2d2c2e37856c2020eeaf84a03d3615 Mon Sep 17 00:00:00 2001 From: Vadim Eisenberg Date: Tue, 10 Jul 2018 18:33:10 +0300 Subject: [PATCH 4/4] move connection.requested_server_name to the end of the dictionary --- mixer/v1/global_dictionary.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mixer/v1/global_dictionary.yaml b/mixer/v1/global_dictionary.yaml index ff54c6264e5..fb72c026889 100644 --- a/mixer/v1/global_dictionary.yaml +++ b/mixer/v1/global_dictionary.yaml @@ -186,7 +186,6 @@ - connection.sent.bytes - connection.sent.bytes_total - connection.duration -- connection.requested_server_name # context attributes - context.protocol @@ -287,3 +286,6 @@ - context.reporter.type - context.reporter.kind + +# SNI, for TLS connections +- connection.requested_server_name