Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix favourites workshops api to return zero elements when you have no favourites selected #310

Closed
DmyMi opened this issue Sep 1, 2021 · 0 comments · Fixed by #359
Closed

Fix favourites workshops api to return zero elements when you have no favourites selected #310

DmyMi opened this issue Sep 1, 2021 · 0 comments · Fixed by #359
Labels
backend Issue involves backend functionality bug Something isn't working priority:high High priority task

Comments

@DmyMi
Copy link
Contributor

DmyMi commented Sep 1, 2021

When user has at least 1 workshop selected as favourite the /Favorite/workshops endpoint returns those selected workshops only. But when the user has 0 favourites selected - /Favorite/workshops endpoint returns all workshops in DB instead of empty list.
@DmyMi DmyMi added bug Something isn't working backend Issue involves backend functionality priority:high High priority task labels Sep 1, 2021
@Bogdan-Hasanov Bogdan-Hasanov linked a pull request Oct 1, 2021 that will close this issue
Checking if there are any favorites in GetFavoriteWorkshopsByUser #359
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Issue involves backend functionality bug Something isn't working priority:high High priority task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Checking if there are any favorites in GetFavoriteWorkshopsByUser ita-social-projects/OoS-Backend
2 participants
@DmyMi @Bogdan-Hasanov