Switch from MySQL.Data to MySqlConnector

[DmyMi]

First step for moving from MySQL to MariadDb

Summary by CodeRabbit

• Chores
  • Updated the MySQL database connectivity by replacing the previous provider with a new, streamlined connector across various system components. This change simplifies dependency management and may enhance overall performance and reliability for database interactions.

[coderabbitai]

Walkthrough

This pull request updates the MySQL dependency across various projects within the repository. The changes remove the MySql.Data package in several project files and replace it with MySqlConnector in others. One file has the dependency simply removed without a replacement, while another project explicitly adds the MySqlConnector package. These modifications affect dependency management for database connectivity without altering any control flow or public API interfaces.

Changes

File(s)	Change Summary
OutOfSchool/Directory.Packages.props, .../OutOfSchool.AuthorizationServer.csproj, .../OutOfSchool.WebApi.csproj	Replaced MySql.Data with MySqlConnector (version update in the props file from 8.4.0 to 2.4.0)
.../OutOfSchool.BusinessLogic.csproj, .../OutOfSchool.WebApi.Tests.csproj	Removed the MySql.Data package reference without adding a replacement
.../OutOfSchool.Migrations.csproj	Added a new package reference for MySqlConnector

Possibly related PRs

• Update Openiddict to 6.x & 'fix' token pruning bug #1675: Updates MySQL package references from MySql.Data to MySqlConnector in similar project files.

Suggested reviewers

• h4wk13
• VadymLevkovskyi

Poem

In the code fields I hop along,
Switching packages as I sing my song.
MySql.Data out, MySqlConnector in clear view,
With each change, something fresh and new.
A bunny cheer for changes made so true!
(_/)   🐰
CodeRabbit leaps; oh what a breakthrough!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8907a55 and b2911dd.

📒 Files selected for processing (6)

• OutOfSchool/Directory.Packages.props (1 hunks)
• OutOfSchool/OutOfSchool.AuthorizationServer/OutOfSchool.AuthorizationServer.csproj (1 hunks)
• OutOfSchool/OutOfSchool.BusinessLogic/OutOfSchool.BusinessLogic.csproj (0 hunks)
• OutOfSchool/OutOfSchool.Migrations/OutOfSchool.Migrations.csproj (1 hunks)
• OutOfSchool/OutOfSchool.WebApi.Tests/OutOfSchool.WebApi.Tests.csproj (0 hunks)
• OutOfSchool/OutOfSchool.WebApi/OutOfSchool.WebApi.csproj (1 hunks)

💤 Files with no reviewable changes (2)

• OutOfSchool/OutOfSchool.WebApi.Tests/OutOfSchool.WebApi.Tests.csproj
• OutOfSchool/OutOfSchool.BusinessLogic/OutOfSchool.BusinessLogic.csproj

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: test (macOS-latest)
• GitHub Check: test (windows-latest)
• GitHub Check: test (ubuntu-latest)
• GitHub Check: SonarCloud

🔇 Additional comments (4)

OutOfSchool/OutOfSchool.Migrations/OutOfSchool.Migrations.csproj (1)

17-17: Correctly adding MySqlConnector package

Adding the MySqlConnector package reference aligns with the PR objective of transitioning from MySQL to MariaDB. This is a good first step in the migration process.

OutOfSchool/OutOfSchool.AuthorizationServer/OutOfSchool.AuthorizationServer.csproj (1)

35-35: Consistent package usage across projects

Adding MySqlConnector here maintains consistency with the migration approach across the solution. Good job on ensuring all related projects receive the appropriate package reference.

OutOfSchool/OutOfSchool.WebApi/OutOfSchool.WebApi.csproj (1)

56-56: Replaced MySql.Data with MySqlConnector

The change correctly replaces the MySql.Data package with MySqlConnector, which is consistent with the migration approach in other project files.

OutOfSchool/Directory.Packages.props (1)

45-45:

✅ Verification successful

Centralized package version management

Good job on updating the centralized package version management file with the new MySqlConnector package version (2.4.0). This ensures consistency across all projects that reference this package.

You may want to verify that this version of MySqlConnector is fully compatible with your MariaDB version:

---

🌐 Web query:

Is MySqlConnector 2.4.0 compatible with the latest versions of MariaDB?

💡 Result:

MySqlConnector 2.4.0 maintains compatibility with modern MariaDB server versions due to its design as a general-purpose MySQL/MariaDB ADO.NET provider[3][7]. Key points:

Compatibility Overview:

• Officially supports MariaDB, MySQL Server, Amazon Aurora, Azure Database for MySQL[3]
• Uses standard MySQL protocol implementation[3], ensuring interoperability with servers supporting this protocol

Key Compatibility Features:

1. Protocol Support: Implements current authentication methods and wire protocols used by modern MariaDB versions[3][7]
2. Feature Alignment: Includes fixes like server redirection logic updates (yavoda/add endpoint for competitive selection description #1499) and variable renaming (Ydzys/specify kind of date in changes logs to utc #1502) for better server compatibility[7]
3. Version Testing: Actively maintained against current database versions (as of its 2023 release cycle)[3][7]

Limitations to Consider:

• While compatible with major features, some very new MariaDB-specific functionalities introduced after MySqlConnector 2.4.0's release might require newer driver versions
• Amazon RDS users should verify instance compatibility - supported RDS MariaDB versions include up to 11.4.x series[2]

For production deployments using features from MariaDB ≥11.x series, testing connectivity and feature support with MySqlConnector 2.4.x in a staging environment is recommended before full deployment[3][7].

Citations:

• 1: https://mariadb.com/kb/en/about-mariadb-connector-j/
• 2: https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/MariaDB.Concepts.VersionMgmt.html
• 3: https://www.nuget.org/packages/MySqlConnector
• 4: https://mariadb.com/kb/en/mariadb-server-release-dates/
• 5: https://mariadb.com/kb/en/mariadb-connector-j-240-release-notes/
• 6: https://mariadb.org/mariadb/all-releases/
• 7: https://mysqlconnector.net/overview/version-history/
• 8: https://mariadb.org/download/
• 9: https://www.nuget.org/packages/MySqlConnector.DependencyInjection/
• 10: https://mariadb.com/newsroom/press-releases/mariadb-announces-new-release-of-its-enterprise-platform-with-introduction-of-vector-search-for-ai-application-development/

---

Verified: MySqlConnector 2.4.0 is compatible with modern MariaDB versions

Great work updating the centralized package version management file with MySqlConnector 2.4.0. The web query confirms that version 2.4.0 maintains compatibility with current MariaDB server versions via its standard MySQL protocol support. Just keep in mind that if you plan on using any MariaDB-specific features introduced after 2.4.0’s release, it’s wise to test those in a staging environment.

• File: OutOfSchool/Directory.Packages.props at line 45
• Confirmed compatibility for general database functionalities
• Consider additional testing for advanced MariaDB features if applicable

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud