Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp show: sort commits #7263

Closed
dberenbaum opened this issue Jan 13, 2022 · 7 comments
Closed

exp show: sort commits #7263

dberenbaum opened this issue Jan 13, 2022 · 7 comments
Labels
A: experiments Related to dvc exp diff/show Related to the diff/show feature enhancement Enhances DVC p3-nice-to-have It should be done this or next sprint

Comments

@dberenbaum
Copy link
Collaborator

It's currently only possible to sort experiments within their parent commit, but it can also be useful to sort the actual commits, tags, or branches themselves. It would be nice to have some option like --sort-commits, --sort-parents, or similar.

See https://discuss.dvc.org/t/dvc-exp-show-experiment-not-showing-wrong-position/1019/1

@dberenbaum dberenbaum added the A: experiments Related to dvc exp label Jan 13, 2022
@daavoo daavoo added diff/show Related to the diff/show feature enhancement Enhances DVC labels Jan 13, 2022
@dberenbaum
Copy link
Collaborator Author

@shcheklein @tapadipti What do you think about this for Studio? Have you seen any requests to sort across branches?

@shcheklein
Copy link
Member

The only slightly related one is this one iterative/studio-support#44 . That's all that comes to my mind, @dberenbaum . May be Tapa can remember more.

btw, @mattseddon I think we decided in VS Code to sort actual parents (and keep checkpoints as-is) or what is the current mode?

@mattseddon
Copy link
Member

btw, @mattseddon I think we decided in VS Code to sort actual parents (and keep checkpoints as-is) or what is the current mode?

That's correct, we only sort experiments and leave their checkpoints alone.

@dberenbaum
Copy link
Collaborator Author

Sorry for being unclear, this is not related to checkpoints. By parent commit, I mean the branch, tag, or regular Git commit from which the experiment originated.

For example:

  Experiment                Created        dvclive.json:epoch   dvclive.json:mult   step
 ───────────────────────────────────────────────────────────────────────────────────────
  workspace                 -                              31                  31      -
  exp                       Feb 09, 2021                    1                   -      0
  main                      Mar 10, 2021                    -                   -      -
  │ ╓ 3d73342 [exp-eae92]   Oct 25, 2021                   13                  13     10
  │ ╟ 61fd39f (e00e3e3)     Oct 25, 2021                   12                  12     10
  │ ╓ 8a03e76 [exp-6c0d3]   Oct 25, 2021                   11                  11     10
  ├─╨ 9fd6c44               Oct 25, 2021                   10                  10     10
  │ ╓ e00e3e3 [exp-9d3f2]   Oct 25, 2021                    4                   4      0
  │ ╟ 3ed4eaa               Oct 25, 2021                    3                   3      0
  │ ╟ 56a23a6               Oct 25, 2021                    2                   2      0
  ├─╨ 391628f               Oct 25, 2021                    1                   1      0
  mynewexp                  Feb 09, 2021                    3                   -    100 
 ───────────────────────────────────────────────────────────────────────────────────────

Not the best example, but this is about sorting between exp, main, and mynewexp. Not sure if that's relevant for VS Code, or if you always show only experiments based on the current workspace.

@mattseddon
Copy link
Member

Right now we only show experiments for the current workspace. This would be a future question/problem for us, not immediate 👍🏻 .

@tapadipti
Copy link
Contributor

The only slightly related one is this one iterative/studio-support#44 . That's all that comes to my mind, @dberenbaum . May be Tapa can remember more.

There's another one related to comparing results across branches (https://github.com/iterative/cse/issues/17). But this also isn't about sorting across branches.

@dberenbaum dberenbaum added the p3-nice-to-have It should be done this or next sprint label Feb 6, 2023
@dberenbaum
Copy link
Collaborator Author

Not in current plans

@dberenbaum dberenbaum closed this as not planned Won't fix, can't repro, duplicate, stale Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Related to dvc exp diff/show Related to the diff/show feature enhancement Enhances DVC p3-nice-to-have It should be done this or next sprint
Projects
None yet
Development

No branches or pull requests

5 participants