Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exp: apply should keep stash and hint at how to recover pre-apply workspace #7955

Closed
dberenbaum opened this issue Jun 30, 2022 · 1 comment · Fixed by #8994
Closed

exp: apply should keep stash and hint at how to recover pre-apply workspace #7955

dberenbaum opened this issue Jun 30, 2022 · 1 comment · Fixed by #8994
Assignees
@pmrowla
Labels
A: experiments Related to dvc exp p1-important Important, aka current backlog of things to do

Comments

@dberenbaum
Copy link
Collaborator

Related to #6930 and iterative/vscode-dvc#1956.

When doing dvc exp apply, it's possible to overwrite dirty changes in your workspace. We already stash those changes to merge them as part of apply. If we retain that stash and hint to users how to recover it, we will avoid the possibility that users lose their work.

@pmrowla Do we stash untracked changes too?
@dberenbaum dberenbaum mentioned this issue Jun 30, 2022
Closed
@dberenbaum dberenbaum added the A: experiments Related to dvc exp label Jun 30, 2022
@dberenbaum dberenbaum mentioned this issue Nov 2, 2022
Closed
@dberenbaum dberenbaum mentioned this issue Dec 9, 2022
Closed
@dberenbaum dberenbaum added the p1-important Important, aka current backlog of things to do label Dec 21, 2022
@dberenbaum dberenbaum added this to DVC Dec 21, 2022
@dberenbaum dberenbaum moved this to Backlog in DVC Dec 21, 2022
@pmrowla
Copy link
Contributor

pmrowla commented Dec 26, 2022

@pmrowla Do we stash untracked changes too?

Yes, we stash the untracked changes before applying

@dberenbaum dberenbaum mentioned this issue Jan 5, 2023
Closed
@pmrowla pmrowla mentioned this issue Feb 9, 2023
Merged
2 tasks
@dberenbaum dberenbaum moved this from Backlog to In Progress in DVC Feb 15, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in DVC Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmrowla pmrowla

Labels
A: experiments Related to dvc exp p1-important Important, aka current backlog of things to do
Projects
No open projects
DVC
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

exp apply: allow apply from other commits pmrowla/dvc
2 participants
@pmrowla @dberenbaum