Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

studio: STUDIO_REPO_URL needs to be set to live share experiments run from the queue #485

Closed
mattseddon opened this issue Mar 6, 2023 · 6 comments

Comments

@mattseddon
Copy link
Member

Noticed when working on iterative/vscode-dvc#3398. In order to live share experiments that are running in the queue I have to start the queue (dvc queue start) with not only the STUDIO_TOKEN but also STUDIO_REPO_URL. This seems to be caused by git ls-remote --get-url not working for experiments that are being run from the queue. It appears that the remote is not respected in the created temp directory. E.g:

/.dvc/tmp/exps/tmpayme39b7 @950c246e !2 ❯ git ls-remote --get-url
fatal: No remote configured to list refs from.

Not sure if this is expected behaviour or not. From what I can see STUDIO_REPO_URL is no longer mentioned in the docs. Happy to close and reopen elsewhere if this is not the correct place for this issue 🙏🏻.

@daavoo
Copy link
Contributor

daavoo commented Mar 6, 2023

Hei @mattseddon sorry for the lack of communication here.

Not sure if this is expected behaviour or not.

It is not expected but I commented in iterative/dvc#8951 (comment) that it could be considered a particular case of iterative/dvc#5800 , which is already prioritized in DVC as part of iterative/dvc#8972 .

Other issues were considered a higher priority because setting the env var can be used as a workaround for this one.

From what I can see STUDIO_REPO_URL is no longer mentioned in the docs.

I didn't realize that it was completely removed, as far as I remember I added a mention of exp queue requiring the env var.

Happy to close and reopen elsewhere if this is not the correct place for this issue 🙏🏻.

It needs to be addressed on DVC repo, you can comment at iterative/dvc#5800 or iterative/dvc#8972

@daavoo
Copy link
Contributor

daavoo commented Mar 6, 2023

Closing this one as there is no action to be taken in DVCLive

@daavoo daavoo closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2023
@dberenbaum
Copy link
Collaborator

@daavoo Is your suggestion is that the git remotes must be copied over during exp run?

@daavoo
Copy link
Contributor

daavoo commented Mar 6, 2023

@daavoo Is your suggestion is that the git remotes must be copied over during exp run?

I am not sure if it's better to copy .git/config or try to repurpose an existing mechanism we have to set env vars inside the exp

@dberenbaum
Copy link
Collaborator

Added to iterative/dvc#9074.

@daavoo
Copy link
Contributor

daavoo commented Mar 13, 2023

Should be fixed in iterative/dvc#9161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants