-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source control panel: differentiate from Git more #1849
Comments
The API that we have to use to display anything inside of the SCM view is pretty limited. It is intentionally set up by VS Code for everything to have a similar look and feel. Granted this does take some getting used to. This could also be because I use VS Code a lot and always use the SCM view to see where I'm at in terms of the current commit, but to me, it is obvious where the Git tree ends and where the DVC one starts. I have highlighted the differences that I use/see from your picture: The biggest difference is that the Git tree has a big commit message box at the top of the tree. I used to use this a lot before switching completely back to the command line. The next difference is the tree name: Git vs DVC. And the final one is the difference in icons at the top of each tree. We have purposefully matched the file decorations so as to integrate with the Git extension. IIRC this is because:
|
Let's close this for now, this will depend on the users feedback going forward |
Further reading on SCM: #772 |
I'm pretty sure it won't be obvious to most users, especially at first. But anyway, sounds like we're somewhat limited by the VS Code API.
Perhaps this is where the design could differentiate itself if users do in fact get lost here. We shall see! |
The DVC panel in the SC view looks a LOT like Git's.
Regardless of whether we intend or not to make it look like "(almost) the same thing but for data" visually (do we?), to me it's just hard to tell where one panel ends and the other one starts.
The text was updated successfully, but these errors were encountered: