From f9c1910ad07183342a62a9d4902d327c9ca8dc38 Mon Sep 17 00:00:00 2001 From: jekuaitk Date: Fri, 23 Aug 2024 15:11:58 +0200 Subject: [PATCH 1/3] Only get published texts --- web/modules/custom/giv_din_stemme/src/Helper/Helper.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/web/modules/custom/giv_din_stemme/src/Helper/Helper.php b/web/modules/custom/giv_din_stemme/src/Helper/Helper.php index 706cc92f..b338656e 100644 --- a/web/modules/custom/giv_din_stemme/src/Helper/Helper.php +++ b/web/modules/custom/giv_din_stemme/src/Helper/Helper.php @@ -44,12 +44,13 @@ public function getFrontpageValues(): array { } /** - * Gets random Text. + * Gets random published Text. */ public function getRandomText(): EntityInterface { $nodes = $this->entityTypeManager->getStorage('node')->loadByProperties([ 'type' => 'text', + 'status' => 1, ]); $count = count($nodes); From 00bbd69a63d19600e1de11f999db2e6167de3d06 Mon Sep 17 00:00:00 2001 From: jekuaitk Date: Fri, 23 Aug 2024 15:13:52 +0200 Subject: [PATCH 2/3] Renamed method --- .../giv_din_stemme/src/Controller/GivDinStemmeController.php | 2 +- web/modules/custom/giv_din_stemme/src/Helper/Helper.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/web/modules/custom/giv_din_stemme/src/Controller/GivDinStemmeController.php b/web/modules/custom/giv_din_stemme/src/Controller/GivDinStemmeController.php index dfb9fced..be10bffa 100644 --- a/web/modules/custom/giv_din_stemme/src/Controller/GivDinStemmeController.php +++ b/web/modules/custom/giv_din_stemme/src/Controller/GivDinStemmeController.php @@ -175,7 +175,7 @@ public function thankYou(Request $request): array { * and redirects to the first. */ public function startDonating(Request $request): RedirectResponse { - $text = $this->helper->getRandomText(); + $text = $this->helper->getRandomPublishedText(); $collectionId = $this->helper->generateUuid(); $delta = 0; diff --git a/web/modules/custom/giv_din_stemme/src/Helper/Helper.php b/web/modules/custom/giv_din_stemme/src/Helper/Helper.php index b338656e..48d9a65b 100644 --- a/web/modules/custom/giv_din_stemme/src/Helper/Helper.php +++ b/web/modules/custom/giv_din_stemme/src/Helper/Helper.php @@ -46,7 +46,7 @@ public function getFrontpageValues(): array { /** * Gets random published Text. */ - public function getRandomText(): EntityInterface { + public function getRandomPublishedText(): EntityInterface { $nodes = $this->entityTypeManager->getStorage('node')->loadByProperties([ 'type' => 'text', From b3d45a9bdd0fd98d07c1ddf0162a561e897bd248 Mon Sep 17 00:00:00 2001 From: jekuaitk Date: Fri, 23 Aug 2024 16:07:29 +0200 Subject: [PATCH 3/3] Updated CHANGELOG --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 468f8d7b..12586902 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,8 @@ See [keep a changelog] for information about writing changes to this log. ## [Unreleased] +* [PR-19](https://github.com/itk-dev/giv-din-stemme/pull/19) + Only get published texts. * [PR-16](https://github.com/itk-dev/giv-din-stemme/pull/16) Development OIDC fixes * [PR-13](https://github.com/itk-dev/giv-din-stemme/pull/13)