Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy images #153

Closed
theel0ja opened this issue Sep 5, 2018 · 12 comments
Closed

Proxy images #153

theel0ja opened this issue Sep 5, 2018 · 12 comments

Comments

@theel0ja
Copy link

theel0ja commented Sep 5, 2018

I understand why you can't proxy videos, but please at least proxy images...

screen shot 2018-09-05 at 20 30 10

@dimqua
Copy link
Contributor

dimqua commented Sep 5, 2018

Not only images, but external CSS and JS also.

@omarroth
Copy link
Contributor

omarroth commented Sep 6, 2018

+1. This can be used as a solution for grabbing the highest quality thumbnail for video posters. Because YouTube provides inconsistent thumbnails, it would be nice to say /img/AAAAAAAAAAA.jpg and have Invidious automatically determine the highest it can provide without adding latency to the initial /watch?v=AAAAAAAAAAA request.

CSS and JS also shouldn't be a problem, and will allow some changes necessary for #34 to be tested before they're published upstream.

@omarroth
Copy link
Contributor

omarroth commented Sep 7, 2018

As a short update: assets are now hosted locally with 3ec684a.

@omarroth
Copy link
Contributor

Thumbnails are now proxied with 429a4b2, it also automagically pulls the highest resolution thumbnail for videos, which is pretty nice. I think the only thing that needs to be proxied now is author thumbs, and we can close this.

@theel0ja
Copy link
Author

Great. However, some pages like https://invidio.us/watch?v=yErnuebA9Yo are still downloading some video thumbnails from Google/YouTube.

@theel0ja
Copy link
Author

@omarroth
Copy link
Contributor

Looks like it's still pulling thumbs for related videos. Should be fixed by 3ccee12.

@theel0ja
Copy link
Author

Watch pages aren't working anymore. Returns an error.

@omarroth
Copy link
Contributor

What error is it returning?

@theel0ja
Copy link
Author

In the title, there was "Error - Invidious". However, it's working now.

@theel0ja
Copy link
Author

Fixed 😄 (user photos not yet though)

@theel0ja
Copy link
Author

#168 for user photos

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants