Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add support for multiples audio tracks #2007

Closed
SapeurPonpier opened this issue Apr 10, 2021 · 24 comments · Fixed by #5149 · May be fixed by #4985
Closed

[Enhancement] Add support for multiples audio tracks #2007

SapeurPonpier opened this issue Apr 10, 2021 · 24 comments · Fixed by #5149 · May be fixed by #4985
Labels
enhancement Improvement of an existing feature type:client-side The user interface of invidious

Comments

@SapeurPonpier
Copy link

I started watching a video ( https://yewtu.be/watch?v=fMfipiV_17o ) from MrBeast, which is a famous English-speaking channel. However, the audio was in Spanish. It seems like YouTube implemented the feature of separate audio tracks and that not only are we not able to pick which one we would like to hear (unlike on the youtube player) but that it defaulted to Spanish. Which is fine by me cause I speak a bit Spanish and it trains me but still ... it might become tedious when I come accross a video with Chinese dubs, I would most definetly not understand anything.

We probably need to add a feature to enable selection of audio track.

@SapeurPonpier SapeurPonpier added the bug Something isn't working label Apr 10, 2021
@TheFrenchGhosty TheFrenchGhosty changed the title [Bug] Audio tracks not supported [Enhancement] Add support for multiples audio tracks Apr 10, 2021
@TheFrenchGhosty TheFrenchGhosty added enhancement Improvement of an existing feature priority:high type:client-side The user interface of invidious and removed bug Something isn't working labels Apr 10, 2021
@TheFrenchGhosty
Copy link
Member

Adding supports for multiples audio track is needed in the player, or if videojs doesn't support multiples audio track, directly in the invidious UI.

Or alternatively just make it use the "default" one.

@unixfox
Copy link
Member

unixfox commented Dec 4, 2023

Notice: https://yewtu.be uses a custom backend, so the language selection is available.

image

This does not mean that invidious support it natively. it's just a yewtu.be thing

@d4g
Copy link

d4g commented Jan 14, 2024

I would kindly ask to not see this as an enhancement but as a bug.
It's not an enhancement to play a video in the original language and it's not an enhancement to be able to select the original language if a different langauge is played back. This is a bug. As more and more issues regarding this are created, I would be interested if this is under investigation or postponed into oblivion?

@mas1701
Copy link

mas1701 commented Feb 1, 2024

I would kindly ask to not see this as an enhancement but as a bug. It's not an enhancement to play a video in the original language and it's not an enhancement to be able to select the original language if a different langauge is played back. This is a bug. As more and more issues regarding this are created, I would be interested if this is under investigation or postponed into oblivion?

With more and more AI translations, the number of multilanguage videos will most likely increase rapidly. So IMO this is too significant to ignore. I just stumbled upon a german car review video playing in french. 👎

@TheFrenchGhosty TheFrenchGhosty pinned this issue Feb 4, 2024
@Bounzzer

This comment has been minimized.

@stegl

This comment has been minimized.

@saukkico

This comment has been minimized.

@Fnconst

This comment has been minimized.

@kladderadeng

This comment was marked as duplicate.

@RichyHBM
Copy link

RichyHBM commented Jan 3, 2025

Until a better solution comes up, maybe the immediate fix could be to always fetch a video in its original language?

@ggtylerr
Copy link

ggtylerr commented Jan 3, 2025

Until a better solution comes up, maybe the immediate fix could be to always fetch a video in its original language?

I'm not sure if it's already mentioned in the thread but companion already does this. Only reason why the issue is still open is cause the patches haven't been merged to master yet.

@stegl

This comment was marked as duplicate.

@pimlie
Copy link

pimlie commented Jan 6, 2025

Is there any workaround for this issue? Or should users already start using companion?

@RichyHBM
Copy link

I've been out of the loop somewhat, what is companion?
As for a work around, if you change your resolution in the setting from dash to something else it seems to fix it

@syeopite
Copy link
Member

Support for videos with multiple audio tracks has been merged! Please let us know if you discover any issues with this feature

@ildoc
Copy link

ildoc commented Jan 24, 2025

Will it be possible to set the original audio track as the default one?

@syeopite
Copy link
Member

The PR should've already set the original audio track as the default one

@ildoc
Copy link

ildoc commented Jan 24, 2025

for example watch?v=QRwMmw7a0VQ is set on english track while the original audio is in italian

I also tried to change the user language, but the default track is always in english

@matzzze
Copy link

matzzze commented Jan 24, 2025

for example watch?v=QRwMmw7a0VQ is set on english track while the original audio is in italian

I also tried to change the user language, but the default track is always in english

just updated my resident invidious (not companion but classic with inv_sig_helper & po_token ) and i can confirm it still plays in English

@ildoc
Copy link

ildoc commented Jan 24, 2025

I've opened an issue just to keep track of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature type:client-side The user interface of invidious
Projects
Status: Done