Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Wrong tiles in story board #3440

Closed
iBicha opened this issue Nov 27, 2022 · 5 comments
Closed

[Bug] Wrong tiles in story board #3440

iBicha opened this issue Nov 27, 2022 · 5 comments
Labels
question Further information is requested

Comments

@iBicha
Copy link
Contributor

iBicha commented Nov 27, 2022

Describe the bug
/videos/:id returns wrong storyboardHeight

Steps to Reproduce

  1. /api/v1/videos/UhbixyxgsiU
  2. returns 3 storyboards. The second storyboard returns
         "url":"/api/v1/storyboards/UhbixyxgsiU?width=60&height=45",
         "templateUrl":"https://i.ytimg.com/sb/UhbixyxgsiU/storyboard3_L1/M$M.jpg?sqp=-oaymwENSDfyq4qpAwVwAcABBqLzl_8DBgjBmdybBg%3D%3D&sigh=rs%24AOn4CLBujIIzxs6-nY318GTi_j8tt52HAw",
         "width":60,
         "height":45,
         "count":74,
         "interval":2000,
         "storyboardWidth":10,
         "storyboardHeight":10,
         "storyboardCount":1

The image is actually 10x8, not 10x10, making the storyboardHeight field wrong

Logs

Screenshots
Screen Shot 2022-11-27 at 6 44 50 PM

@iBicha iBicha added the bug Something isn't working label Nov 27, 2022
@iBicha
Copy link
Contributor Author

iBicha commented Nov 28, 2022

I see many more cases of this. 10x5 reported as 10x10

         "url":"/api/v1/storyboards/Gb4ghMzz0a4?width=25&height=45",
         "templateUrl":"https://i.ytimg.com/sb/Gb4ghMzz0a4/storyboard3_L1/M$M.jpg?sqp=-oaymwENSDfyq4qpAwVwAcABBqLzl_8DBgicmuCbBg%3D%3D&sigh=rs%24AOn4CLA7AtTjMrWA77A6PaTdlV8QL6jxNg",
         "width":25,
         "height":45,
         "count":48,
         "interval":1000,
         "storyboardWidth":10,
         "storyboardHeight":10,
         "storyboardCount":1

Screen Shot 2022-11-27 at 8 04 49 PM

@SamantazFox
Copy link
Member

Oh, that's interesting! The code always assumed 10x10, but seems like things have changed (probably because of shorts and other newer formats?).

@SamantazFox SamantazFox added type:youtube-change Google changed something (again) module:player Impacts the video player of Invidious labels Nov 29, 2022
@SamantazFox
Copy link
Member

Actually, it seems normal?

The storyboardWidth and storyboardHeight represent the maximum amount of storyboards you can get on each axis per image. But the last image in the set (or the only image, in case of short videos) may have less than that!

Here is the output for a long video (livestream):

{
	"videoId": "etyCb38ag-s",
	"storyboards": [
		{
			"url": "/api/v1/storyboards/etyCb38ag-s?width=48&height=27",
			"templateUrl": "https://i.ytimg.com/sb/etyCb38ag-s/storyboard3_L0/M$M.jpg",
			"width": 48,
			"height": 27,
			"count": 100,
			"interval": 0,
			"storyboardWidth": 10,
			"storyboardHeight": 10,
			"storyboardCount": 1
		},
		{
			"url": "/api/v1/storyboards/etyCb38ag-s?width=80&height=45",
			"templateUrl": "https://i.ytimg.com/sb/etyCb38ag-s/storyboard3_L1/M$M.jpg",
			"width": 80,
			"height": 45,
			"count": 1414,
			"interval": 10000,
			"storyboardWidth": 10,
			"storyboardHeight": 10,
			"storyboardCount": 15
		},
		{
			"url": "/api/v1/storyboards/etyCb38ag-s?width=160&height=90",
			"templateUrl": "https://i.ytimg.com/sb/etyCb38ag-s/storyboard3_L2/M$M.jpg",
			"width": 160,
			"height": 90,
			"count": 1414,
			"interval": 10000,
			"storyboardWidth": 5,
			"storyboardHeight": 5,
			"storyboardCount": 57
		}
	],
}

@iBicha
Copy link
Contributor Author

iBicha commented Oct 8, 2023

@SamantazFox your logic makes sense (I guess I was mislead with some of the 1 pagers)
So after all it's like you said, only shorts are affected scratch that, that's also because they are one page I guess?

@iBicha
Copy link
Contributor Author

iBicha commented Oct 8, 2023

So the format is technically correct? Thanks for clarifying I'll close the issue - please reopen if there's some edge case to it

@iBicha iBicha closed this as completed Oct 8, 2023
@SamantazFox SamantazFox added question Further information is requested and removed bug Something isn't working type:youtube-change Google changed something (again) module:player Impacts the video player of Invidious labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants