Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify ignore file #45

Merged
merged 1 commit into from
Jan 16, 2016
Merged

Simplify ignore file #45

merged 1 commit into from
Jan 16, 2016

Conversation

vinkla
Copy link
Owner

@vinkla vinkla commented Aug 23, 2015

Just removed unnecessary ignored files.

@jd327
Copy link
Collaborator

jd327 commented Aug 23, 2015

I haven't seen .DS_Store ignored on my system, that's why I added it initially. tmproj is my TextMate project file.

@vinkla
Copy link
Owner Author

vinkla commented Aug 23, 2015

IMO that should be in the system ignore as well. Like myself, I use PhpStorm a lot but I never add .idea folder to my packages ignore file since the project doesn't care about my choice of editor.

@vinkla
Copy link
Owner Author

vinkla commented Oct 8, 2015

Any update on this?

@jd327
Copy link
Collaborator

jd327 commented Oct 9, 2015

Sorry, been busy with startups lately! Yes, definitely will clean up the last few PRs and push a new version after testing. I want to pick a good time slot so I can do a few updates at once, so please bare with me as I catch up on my backlog.

Same for #46 of course.

@vinkla
Copy link
Owner Author

vinkla commented Oct 9, 2015

No worries, let me know if I can help out with anything!

jd327 pushed a commit that referenced this pull request Jan 16, 2016
@jd327 jd327 merged commit 08dca8f into vinkla:master Jan 16, 2016
@vinkla
Copy link
Owner Author

vinkla commented Jan 16, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants