Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SpecificCharacterSet when writing DICOM data #1088

Closed
ivmartel opened this issue Jan 19, 2022 · 1 comment · Fixed by #1239
Closed

Fix SpecificCharacterSet when writing DICOM data #1088

ivmartel opened this issue Jan 19, 2022 · 1 comment · Fixed by #1239
Labels
bug Something isn't working
Milestone

Comments

@ivmartel
Copy link
Owner

ivmartel commented Jan 19, 2022

The current code (v0.30), when anonymising, tries to write data using the input character encoding. This is not supported by the web 'TextEncoder' that only writes data as UTF-8. The written data is corrupted since the SpecificCharacterSet could not be in sync. This must be fixed to always write with SpecificCharacterSet set to UTF-8 (ISO_IR 192).

@ivmartel ivmartel added the bug Something isn't working label Jan 19, 2022
@ivmartel ivmartel added this to the Future milestone Jan 19, 2022
@ivmartel ivmartel changed the title Fix specific character set for anonymised data Fix SpecificCharacterSet for anonymised data Jan 19, 2022
@ivmartel ivmartel changed the title Fix SpecificCharacterSet for anonymised data Fix SpecificCharacterSet when writing DICOM data Aug 26, 2022
@ivmartel
Copy link
Owner Author

The list of character sets in the 2022a standard: part03/sect_C.12.html#sect_C.12.1.1.2

@ivmartel ivmartel modified the milestones: Future, 0.31.0 Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant