Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix negative index in worldToIndex #1163

Closed
ivmartel opened this issue May 12, 2022 · 2 comments
Closed

Fix negative index in worldToIndex #1163

ivmartel opened this issue May 12, 2022 · 2 comments
Labels
bug Something isn't working enhancement New feature or request
Milestone
0.31.0

Comments

@ivmartel
Copy link
Owner

Some data lead to negative slice position in the geometry.worldToIndex method (see ivmartel/dwv-jqmobile#79). Making sure only positive values are used seems a good (temporary?) solution...

See also #1130.
@ivmartel ivmartel added the bug Something isn't working label May 12, 2022
@ivmartel ivmartel added this to the 0.31.0 milestone May 12, 2022
@ivmartel
Copy link
Owner Author

Abs is not a good idea... it messes up display on the edges...

@ivmartel ivmartel reopened this May 12, 2022
@ivmartel
Copy link
Owner Author

Added a switch for coronal case to order slices differently... not sure of it...

@ivmartel ivmartel added the enhancement New feature or request label Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
0.31.0
Development

No branches or pull requests
1 participant
@ivmartel