Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid race condition in applaunchers #265

Closed
ivmartel opened this issue Aug 30, 2016 · 0 comments
Closed

Avoid race condition in applaunchers #265

ivmartel opened this issue Aug 30, 2016 · 0 comments
Labels
enhancement New feature or request
Milestone
0.17.0

Comments

@ivmartel
Copy link
Owner

The current code of the applauncher, waiting for the DOM to be loaded and then on i18n to be initialised could not run if the events happen in the reverse order. Simple flags could be used to ensure both events have happened before launching, as in this gist: wp-applauncher_new-js. Or maybe promises could be used...
@ivmartel ivmartel added the enhancement New feature or request label Aug 30, 2016
@ivmartel ivmartel added this to the 0.17.0 milestone Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.17.0
Development

No branches or pull requests
1 participant
@ivmartel