Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tensorflow): Add FFT3D function to tensorflow.raw_ops #26727

Merged
merged 7 commits into from
Oct 10, 2023
Merged

feat(tensorflow): Add FFT3D function to tensorflow.raw_ops #26727

merged 7 commits into from
Oct 10, 2023

Conversation

ayomidee-e
Copy link
Contributor

PR Description

feat: add FFT3D function to tensorflow.raw_ops

Fixes #26726

Related Issue

Close #26726

Checklist

  • Added the FFT3D function to tensorflow.raw_ops in raw_ops.py.
  • Created tests for the FFT3D function in test_raw_ops.py.
  • Ensured that all tests are passing.
  • Ran the pre-commit checks without failures.
  • Followed the Ivy project's contribution guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Thank you for this PR, here is the CI results:

This pull request does not result in any additional test failures. Congratulations!

@ayomidee-e ayomidee-e requested a review from KareemMAX as a code owner October 9, 2023 06:38
@KareemMAX
Copy link
Contributor

Hey @Ayo-folashade,

Seems like you modified docs/demos by mistake. Can you revert that change?

@AnnaTz
Copy link
Contributor

AnnaTz commented Oct 9, 2023

Hi @Ayo-folashade the PR looks good! We can merge this after removing the unneeded changes to demos.

@ayomidee-e
Copy link
Contributor Author

Hey @Ayo-folashade,

Seems like you modified docs/demos by mistake. Can you revert that change?

Hi @KareemMAX
Apologies, change reverted.
Thank you

@ayomidee-e
Copy link
Contributor Author

Hi @Ayo-folashade the PR looks good! We can merge this after removing the unneeded changes to demos.

Hi @AnnaTz
Thank you,
I've removed the unneeded changes to demos

@ayomidee-e ayomidee-e closed this Oct 9, 2023
@ayomidee-e ayomidee-e force-pushed the add-FFT3D-function-to-tensorflow.raw_ops branch from f1038e2 to a59ef41 Compare October 9, 2023 11:47
@ayomidee-e ayomidee-e reopened this Oct 9, 2023
@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Oct 9, 2023
@ayomidee-e
Copy link
Contributor Author

ayomidee-e commented Oct 10, 2023 •
edited
Loading

Hello @AnnaTz @KareemMAX @hirwa-nshuti
Could you please help me review and merge

@AnnaTz
Copy link
Contributor

AnnaTz commented Oct 10, 2023

Hello @AnnaTz @KareemMAX @hirwa-nshuti Could you please help me review and merge

Hi @Ayo-folashade, you have removed the changes to demos but you have committed changes to test_array_api. You will need to remove these as well before merging.

@ayomidee-e
Revert "update submodule"
9a8126b 
This reverts commit 690a9a0.
@ayomidee-e
Revert "updates"
278454a 
This reverts commit 462cc35.
@ayomidee-e
Copy link
Contributor Author

ayomidee-e commented Oct 10, 2023 •
edited
Loading

Hi @AnnaTz
I've also removed the changes i made in test_array_api

@AnnaTz
Copy link
Contributor

AnnaTz commented Oct 10, 2023

Hi @AnnaTz I've also removed the changes i made in test_array_api

It doesn't seem so.
image

@ayomidee-e
Copy link
Contributor Author

Hi @AnnaTz
Apologies for the back and forth, I've worked on it

AnnaTz
AnnaTz approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@AnnaTz AnnaTz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@AnnaTz AnnaTz merged commit 3fcaa28 into ivy-llc:main Oct 10, 2023
@ayomidee-e
Copy link
Contributor Author

Thank you @AnnaTz

druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
@ayomidee-e @druvdub
feat(tensorflow): Add FFT3D function to tensorflow.raw_ops (ivy-llc#2…
458afe2 
…6727)

Co-authored-by: @AnnaTz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaTz AnnaTz AnnaTz approved these changes

@Aarsh2001 Aarsh2001 Awaiting requested review from Aarsh2001

@fnhirwa fnhirwa Awaiting requested review from fnhirwa

@KareemMAX KareemMAX Awaiting requested review from KareemMAX

Assignees

@AnnaTz AnnaTz

Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FFT3D
4 participants
@ayomidee-e @KareemMAX @AnnaTz @ivy-leaves