Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] provide commit range for the whole pull request #27

Open
sibelius opened this issue May 29, 2019 · 0 comments
Open

[feature request] provide commit range for the whole pull request #27

sibelius opened this issue May 29, 2019 · 0 comments

Comments

@sibelius
Copy link

Orb version

1.0.2

What happened

It is not showing whole commit range for pull requests

Expected behavior

This is the commits for my pull requests
image

CIRCLE_COMPARE_URL=$(cat CIRCLE_COMPARE_URL.txt)
 COMMIT_RANGE=$(echo $CIRCLE_COMPARE_URL | sed 's:^.*/compare/::g')
 echo "Commit range: $COMMIT_RANGE"

compare url is like this: 068728a95a46...3466429, in the latest commit.
but it should be 29a7e130f034...068728a95a46

We need this because we cancel jobs on pull requests if another commit show up, so we need to run tests based on the whole pull request commit range

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant