Skip to content
This repository has been archived by the owner on Mar 25, 2020. It is now read-only.

Deprecated NodeJS API usage for Buffer instantiation #72

Closed
LuminescentMoon opened this issue Jun 7, 2016 · 4 comments
Closed

Deprecated NodeJS API usage for Buffer instantiation #72

LuminescentMoon opened this issue Jun 7, 2016 · 4 comments

Comments

@LuminescentMoon
Copy link
Contributor

Usage of new Buffer(size):

Usage of new Buffer(array):

@Lord-Ptolemy
Copy link

What about the many people running on LTS?

@izy521
Copy link
Owner

izy521 commented Jun 7, 2016

I think Buffer.from() exists on LTS as well, but I'm not sure. In any ways, I'm not removing it until there's a version that just doesn't support it anymore. The intention was to allow this lib to be usable with 0.10.x and such.

@seishun
Copy link

seishun commented Sep 15, 2017

@izy521 To clarify, do you feel strongly about keeping 0.10 support, or do you just prefer to keep things as-is unless there is a reason to change? (and in the latter case, would a runtime warning for the usage of Buffer() be such a reason?)

@izy521
Copy link
Owner

izy521 commented Oct 29, 2017

Sorry for the late reply @seishun . At this point I'm no longer interested in keeping support for 0.10, or any of the older versions that don't have Buffer.from() or Buffer.alloc/Unsafe(). The next version of my lib will be switching to those methods.

@izy521 izy521 closed this as completed Oct 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants