Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SLF4J instead of java.util.logging #113

Closed
sanmibuh opened this issue Sep 19, 2017 · 6 comments
Closed

Use SLF4J instead of java.util.logging #113

sanmibuh opened this issue Sep 19, 2017 · 6 comments

Comments

@sanmibuh
Copy link
Contributor

Using java.util.logging for logging has a lot of side effect. See this
http://glauche.de/2009/09/09/java-util-logging-vs-slf4j/

For example, we are using this lib into a Grails 2 application. But it doesn't use our logging config. We need to replicate logs formats, because we are using Kibana and we need a predefined format.

I think it could be great using slf4j instead of java.util.logging. This resolves our problem and the performance should be better.

@fmbenhassine
Copy link
Member

Hi,

As I said here, I don't exclude replacing JUL with SL4J.

Thank you for the PR! I added a couple of notes there.
Please take a look to update the PR and it will be ready to merge.

Kr
Mahmoud

@fmbenhassine fmbenhassine added this to the v3.1 milestone Sep 26, 2017
@fmbenhassine
Copy link
Member

Hi,

I've merged your PR, thank you!

Hence, I'm closing this issue.

Kr
Mahmoud

@sanmibuh
Copy link
Contributor Author

Thank you :)

@HJ1AN
Copy link

HJ1AN commented Sep 28, 2017

Hi,

https://github.com/j-easy/easy-rules/blob/master/easy-rules-core/src/main/java/org/jeasy/rules/core/DefaultRulesEngine.java#L244

fact.getValue() == null ? "null" : fact.getValue().toString()

I think String.valueOf(fact.getValue()) is easier here 😀

@fmbenhassine
Copy link
Member

@wg1j good point!

@fmbenhassine
Copy link
Member

@wg1j done here: 4b7ed47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants