Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom rule/rule engine listeners in AbstractRuleEngine #215

Closed
elitacco opened this issue Jun 10, 2019 · 3 comments
Closed

Allow custom rule/rule engine listeners in AbstractRuleEngine #215

elitacco opened this issue Jun 10, 2019 · 3 comments

Comments

@elitacco
Copy link

elitacco commented Jun 10, 2019

After #157 there is no way to remove the default rule and rules engine listeners. It should be possible to create a rule engine with a custom list of rule listeners and rule engine listeners.

@elitacco elitacco changed the title Allow custom rule/rule engine listeners in DefaultRulesEngine Allow custom rule/rule engine listeners in AbstractRuleEngine Jun 10, 2019
@okohub
Copy link

okohub commented Jun 11, 2019

+1 for this one.

This was a breaking change for us. We are removing default listeners when decorating DefaultRulesEngine.

@zhhaojie
Copy link
Contributor

After #157 there is no way to remove the default rule and rules engine listeners. It should be possible to create a rule engine with a custom list of rule listeners and rule engine listeners.

yes, you can register your custom list of rule listeners & rule engine listeners. but there is no way to remove the default listeners.

i wonder what's the reason you remove the defaults ?

@fmbenhassine
Copy link
Member

Default listeners will be removed in next major version (See #223).

I'm closing this issue as a duplicate of #223 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants