Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port of EasyRules in Go #78

Closed
jiminoc opened this issue May 19, 2017 · 7 comments
Closed

Port of EasyRules in Go #78

jiminoc opened this issue May 19, 2017 · 7 comments

Comments

@jiminoc
Copy link

jiminoc commented May 19, 2017

love your library! I did a port of it over to Go. I was hoping to get some eyes on it to see if I missed anything I should include.

thanks :)

https://github.com/CrowdStrike/easyrulesgo

@fmbenhassine
Copy link
Member

fmbenhassine commented May 20, 2017

Hi @jiminoc

I'm glad you like Easy Rules.
It's great to see your go implementation! I'm a golang beginner but I will follow your repo closely.
Please don't hesitate to ask me if you have any question so I can help.

Do you mind if I add a link to your repo in Easy Rules home page? I'm asking for your permission.

Kind regards
Mahmoud

@fmbenhassine
Copy link
Member

I added a link to your repo in the readme. If this is a problem, please let me know and I'll remove it.

I was hoping to get some eyes on it to see if I missed anything I should include.

One of the most significant additions in v3 is the Facts API. This has been requested by many users and actually makes the library more intuitive. But this is quite recent that's why it's not in the go implementation I guess.

Anyway, thank you for this port to golang!

@jiminoc
Copy link
Author

jiminoc commented May 23, 2017

I'll start reading up on the Facts stuff. I've had the Go port done for almost a year so I assume it's come since then. Do you have any reference links? I checked the open issues but only saw one reference to it 2 years ago. thanks for adding it!

@jiminoc
Copy link
Author

jiminoc commented May 23, 2017

looks I found this one #37

@fmbenhassine
Copy link
Member

Yes indeed, it was initially described in issue #37 .

You can find other details in the wiki here: https://github.com/j-easy/easy-rules/wiki/defining-facts

I would love to help if you have any question.

Kind regards
Mahmoud

@fmbenhassine
Copy link
Member

I'm closing this issue for now.

If you have any question, please let me know, I would love to help!

@jiminoc
Copy link
Author

jiminoc commented May 31, 2017

sorry, I was away for a few days. I've been noodling on this and obviously go has some differences and can't do the same kind of annotations. I'll create an issue on the golang project and cc you to move the convo there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants