Add class variable USE_UNIQUE_DUPLICATE_SUFFIX #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackton1
requested changes
Nov 8, 2019
model_clone/mixins/clone.py
Outdated
| @@ -75,8 +76,9 @@ def _create_copy_of_instance(cls, instance): | |||
| .filter(**{'{}__startswith'.format(f.attname): value}) | |||
| .count() | |||
| ) | |||
| if not str(value).isdigit(): | |||
| value += ' {} {}'.format(cls.UNIQUE_DUPLICATE_SUFFIX, count) | |||
| if cls.USE_UNIQUE_DUPLICATE_SUFFIX is True: | |||
There was a problem hiding this comment.
Can this check use ?
if cls.USE_UNIQUE_DUPLICATE_SUFFIX:
...
jackton1
approved these changes
Nov 9, 2019
|
@all-contributors please add @andresp99999 for bugs. |
|
I've put up a pull request to add @andresp99999! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I have the following use case:
a) I have an object with a string field (uuid) that is stored in a 36 character field.
b) I want to use django-clone to create copies of it (including the uuid), however the current implementation append the UNIQUE_DUPLICATE_SUFFIX field and hence the value is larger than the max field size and the save() call fails.
This PR adds a class variable
USE_UNIQUE_DUPLICATE_SUFFIXto disable this behavior.