Skip to content
This repository was archived by the owner on Jul 1, 2022. It is now read-only.

Flaky unit test io.jaegertracing.zipkin.internal.V2SpanConverterTest#testConvertSpanWith128BitTraceId #745

Closed
yurishkuro opened this issue Sep 14, 2020 · 0 comments · Fixed by #746
Closed

Flaky unit test io.jaegertracing.zipkin.internal.V2SpanConverterTest#testConvertSpanWith128BitTraceId #745

yurishkuro opened this issue Sep 14, 2020 · 0 comments · Fixed by #746

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Sep 14, 2020 •
edited
Loading

This is likely related to zero padding of trace IDs. If the test is using random IDs, then it has ~1 in 16 chance to run into it.

io.jaegertracing.zipkin.internal.V2SpanConverterTest > testConvertSpanWith128BitTraceId FAILED
    org.junit.ComparisonFailure: expected:<[]4530fcc74d879887070b...> but was:<[0]4530fcc74d879887070b...>
        at org.junit.Assert.assertEquals(Assert.java:115)
        at org.junit.Assert.assertEquals(Assert.java:144)
        at io.jaegertracing.zipkin.internal.V2SpanConverterTest.testConvertSpanWith128BitTraceId(V2SpanConverterTest.java:310)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not strip leading zeros from trace IDs yurishkuro/jaeger-client-java
1 participant
@yurishkuro