diff --git a/packages/jaeger-ui/src/components/Monitor/ServicesView/index.test.js b/packages/jaeger-ui/src/components/Monitor/ServicesView/index.test.js index 3434f6d1ba..f221ad5674 100644 --- a/packages/jaeger-ui/src/components/Monitor/ServicesView/index.test.js +++ b/packages/jaeger-ui/src/components/Monitor/ServicesView/index.test.js @@ -150,6 +150,15 @@ describe('', () => { expect(wrapper.state().graphWidth).toBe(76); }); + it('should update state after choosing a new timeframe', () => { + const firstGraphXDomain = wrapper.state().graphXDomain; + wrapper.setProps({ + selectedTimeFrame: 3600000 * 2, + }); + + expect(wrapper.state().graphXDomain).not.toBe(firstGraphXDomain); + }); + it('search test', () => { mockFetchServices.mockResolvedValue(['cartservice']); wrapper.setProps({ diff --git a/packages/jaeger-ui/src/components/Monitor/ServicesView/index.tsx b/packages/jaeger-ui/src/components/Monitor/ServicesView/index.tsx index 210a51803e..2ae27d3253 100644 --- a/packages/jaeger-ui/src/components/Monitor/ServicesView/index.tsx +++ b/packages/jaeger-ui/src/components/Monitor/ServicesView/index.tsx @@ -45,6 +45,7 @@ type StateType = { graphWidth: number; serviceOpsMetrics: ServiceOpsMetrics[] | undefined; searchOps: string; + graphXDomain: number[]; }; type TReduxProps = { @@ -105,21 +106,18 @@ const convertServiceErrorRateToPercentages = (serviceErrorRate: null | ServiceMe // export for tests export class MonitorATMServicesViewImpl extends React.PureComponent { graphDivWrapper: React.RefObject; - graphXDomain: number[]; serviceSelectorValue: string = ''; endTime: number = Date.now(); state = { graphWidth: 300, serviceOpsMetrics: undefined, searchOps: '', + graphXDomain: [], }; constructor(props: TProps) { super(props); this.graphDivWrapper = React.createRef(); - - const currentTime = Date.now(); - this.graphXDomain = [currentTime - props.selectedTimeFrame, currentTime]; } componentDidMount() { @@ -130,22 +128,34 @@ export class MonitorATMServicesViewImpl extends React.PureComponent @@ -286,7 +296,7 @@ export class MonitorATMServicesViewImpl extends React.PureComponent @@ -300,7 +310,7 @@ export class MonitorATMServicesViewImpl extends React.PureComponent