DDG for search results is still wrong

[yurishkuro]

The HotROD graph is missing DB nodes. The redis and mysql services do show in the search results, as well as in the regular DAG graph, but not in DDG:

[rubenvp8510]

I'll review this one.

[rubenvp8510]

This happens because the transformation function filters spans to process only spans.kind = "server", it doesn't process client spans. 8cb13c4

Is that the way it should work?

@everett980 @yurishkuro

[yurishkuro]

I think we discussed it a number of times. No, I don't think it's correct. Any transition (as in parent-child span pair) from service X to Y should result in an edge in the graph. The only value there can be in looking at span.kind is if the service is calling itself recursively, vs. just having a bunch of inner spans, in the former we want X-X edge, in the latter - no edge.