Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UiFind does not match spanID with leading 0 #560

Closed
everett980 opened this issue Apr 15, 2020 · 0 comments · Fixed by #567
Closed

UiFind does not match spanID with leading 0 #560

everett980 opened this issue Apr 15, 2020 · 0 comments · Fixed by #567

Comments

@everett980
Copy link
Collaborator

Requirement - what kind of business use case are you trying to solve?

I need to be able to deep link to a given span based on the spanID available in my DB.

Problem - what in Jaeger blocks you from solving the requirement?

Linking to spanID abc does not match spanID 0+abc in trace:
Screen Shot 2020-04-15 at 1 36 49 PM

Proposal - what do you suggest to solve the problem or improve the existing situation?

Change spanID matching logic from spanID === uiFind to spanID.matches(/0*${uiFind}/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix uiFind matches for spans with leading 0s everett980/jaeger-ui
1 participant
@everett980