Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null metricdata in request monitor graph #933

Closed
zdyj3170101136 opened this issue Apr 19, 2022 · 1 comment · Fixed by #934
Closed

null metricdata in request monitor graph #933

zdyj3170101136 opened this issue Apr 19, 2022 · 1 comment · Fixed by #934
Labels

Comments

@zdyj3170101136
Copy link

Describe the bug
only service request rate graph not have data in monitor page.

To Reproduce
Steps to reproduce the behavior:

  1. run jaeger/docker-compose/monitor/docker-compose.yml

Expected behavior
service request graph show data in monitor page.
just like other graph.

Screenshots
截屏2022-04-19 下午4 12 52

Version (please complete the following information):

  • OS: linux
  • Jaeger ui version: v1.22.0
  • Deployment: Docker

Additional context
i think the problem is the null metricdata in https://github.com/jaegertracing/jaeger-ui/blob/main/packages/jaeger-ui/src/components/Monitor/ServicesView/index.tsx#L351.

after change it from
null
to

metrics.serviceMetrics ? metrics.serviceMetrics.service_call_rate : null

everything is well.

@nofar9792
Copy link
Contributor

Hi,
i'm going to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants