Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up on maintaining connections for grpc #1523

Closed
guanw opened this issue May 7, 2019 · 2 comments
Closed

Follow up on maintaining connections for grpc #1523

guanw opened this issue May 7, 2019 · 2 comments

Comments

@guanw
Copy link
Contributor

guanw commented May 7, 2019

Current grpc resolver used by agent to resolve collector address doesn't have the ability to maintain connections like what peer_list_mgr.go did using maintainConnections. Need to investigate if it's necessary to do so with grpc and if it indeed is how to do it.

Originally posted by @yurishkuro in #1498

@yurishkuro
Copy link
Member

I am not sure if we need something explicit for that or not. A way to try this out (could be in the unit tests) is to do this:

  • use fixed discoverer w/ 5 servers and minPeers=3
  • start sending requests, verify all 3 servers are receiving them
  • shut down one of the servers, verify that all requests are going to the other two servers
  • bring up the 3rd server again (must be on the same port), verify all 3 servers are receiving requests

@guanw
Copy link
Contributor Author

guanw commented May 13, 2019

Tested it. Roundrobin will include servers in this case. Cheers.

@guanw guanw closed this as completed May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants