clean-css 5.0.1 leading zeros are not removed

[XhmikosR]

Precheck

Environment

• clean-css version - npm ls clean-css: 5.0.1
• node.js version - node -v: 14.15.5
• operating system: Windows 10

Configuration options

cleancss -O1 specialComments:0 -o 2.css 1.css

Input CSS

• https://github.com/twbs/bootstrap/blob/main/dist/css/bootstrap.css

kbd {
  padding: 0.2rem 0.4rem;
  font-size: 0.875em;
  color: #fff;
  background-color: #212529;
  border-radius: 0.2rem;
}

Actual output CSS

kbd{padding:.2rem .4rem;font-size:.875em;color:#fff;background-color:#212529;border-radius:0.2rem}

Expected output CSS

kbd{padding:.2rem .4rem;font-size:.875em;color:#fff;background-color:#212529;border-radius:.2rem}

I noticed more cases, not only border-radius and it seems to only happen for rems.

[jakubpawlowicz]

Hey @XhmikosR - by saying "I noticed more cases" do you mean more cases of border-radius or other properties too?

[XhmikosR]

I meant more CSS properties. It's like it's unrelated to the CSS property but specific to rem.

You can try the branch if you want to check the diff https://github.com/twbs/bootstrap/tree/main-xmr-update-cleancss

[XhmikosR]

FYI this is the size diff compared to clean-css v4.

[jakubpawlowicz]

Thanks, I'll have a look and fix it.

[jakubpawlowicz]

^ this should do the trick, please have a quick look at b8c2657#diff-ec858cb5d55ea11dd5f18cb15cfd49435b1bb3cfb1833eee78398b17ac0dd527 if it looks ok to you.

[XhmikosR]

Thanks for taking a look, I really appreciate it!

https://ja2r7.app.goo.gl/cVvQAgjcNbovnGNZ7

It seems there are more cases, like this one:

.progress-bar-striped {
  background-image: linear-gradient(45deg, rgba(255, 255, 255, 0.15) 25%, transparent 25%, transparent 50%, rgba(255, 255, 255, 0.15) 50%, rgba(255, 255, 255, 0.15) 75%, transparent 75%, transparent);
  background-size: 1rem 1rem;
}

0.15 isn't converted to .15.

I'd just check out my upstream branch and as long as the output is the same, then we should be good to go :)

[jakubpawlowicz]

@XhmikosR I get the same output now. I'm gonna merge it and release it.

[XhmikosR]

@jakubpawlowicz confirmed! https://ja2r7.app.goo.gl/mmukonhXTrqKtQLr7

[XhmikosR]

I tried our v4-dev branch too and seems to be fine too:

• twbs/bootstrap@v4-dev...v4-dev-xmr-update-clean-css
• https://ja2r7.app.goo.gl/xCkhQK5vEmXYmHhe7

[jakubpawlowicz]

It's out as clean-css 5.1.0 and clean-css-cli 5.2.0. Thanks for testing!