Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Can we update jquery dependencies? #92

Closed
fsmanuel opened this issue Feb 8, 2014 · 8 comments
Closed

Can we update jquery dependencies? #92

fsmanuel opened this issue Feb 8, 2014 · 8 comments

Comments

@fsmanuel
Copy link

fsmanuel commented Feb 8, 2014

The bower.json states a jquery ~1.7 dependency.
I read the code and found jQuery.isFunction, this.$().attr() and view.$(). It should work with a newer jQuery version. Maybe just change it to >=1.7

@fsmanuel
Copy link
Author

fsmanuel commented Feb 8, 2014

i found your comment. so we should consider/figure out that before.

@jamesarosen
Copy link
Owner

It looks like the attr/prop change was in jQuery 1.6. I think ~1.7 should be fine. I haven't run any tests against 2.0+, so I'd be wary of just claiming compatibility.

@jamesarosen
Copy link
Owner

Oh, it already is ~1.7. I'll try testing against 2.0+.

@jamesarosen
Copy link
Owner

I've gotten lost in a deep yak-shave on this one. This project tests against multiple sets of runtime dependencies. Unfortunately, Bower doesn't support multiple, parallel packages (cf bower/bower#867). That means that we need to have a whole slew of curl targets in the Makefile to fetch the various development dependencies. I can just add two more -- jQuery 2.0.3 and jQuery 2.1.0, but that's just making our problem worse.

I'm going to try moving the build scripts around a little to reduce the noise. Maybe that will make testing on these newer versions of jQuery less painful.

Blargh, JavaScript developer tools.

@fsmanuel
Copy link
Author

fsmanuel commented Feb 9, 2014

poor james! sorry for all that...

@jamesarosen
Copy link
Owner

I just released v1.6.1, which relaxes the dependency to ">=1.7 <3". Note, however, that the latest release version of Ember.View only works with up to jQuery 2.0. There's nothing this library can do about that.

@Kerrick
Copy link

Kerrick commented Feb 10, 2014

Oh dear. Github's watch feature should be more careful with emailing about releases.

screen shot 2014-02-09 at 9 56 22 pm

@fsmanuel
Copy link
Author

@jamesarosen thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants